[heft] Fix incremental copy cache file (#4950)

Co-authored-by: David Michon <dmichon-msft@users.noreply.github.com>
microsoft · Sep 30, 2024 · 0657762 · 0657762
1 parent a06c97d
commit 0657762
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/apps/heft/src/pluginFramework/IncrementalBuildInfo.ts b/apps/heft/src/pluginFramework/IncrementalBuildInfo.ts
@@ -171,7 +171,7 @@ export async function writeBuildInfoAsync(state: IIncrementalBuildInfo, filePath
   const serializedBuildInfo: ISerializedIncrementalBuildInfo = serializeBuildInfo(
     state,
     (absolutePath: string) => {
-      return makePathRelative(basePath, absolutePath);
+      return makePathRelative(absolutePath, basePath);
     }
   );
 

diff --git a/apps/heft/src/plugins/CopyFilesPlugin.ts b/apps/heft/src/plugins/CopyFilesPlugin.ts
@@ -186,7 +186,9 @@ async function _copyFilesInnerAsync(
     oldBuildInfo = undefined;
   }
 
-  const inputFileVersions: Map<string, string> = new Map();
+  // Since in watch mode only changed files will get passed in, need to ensure that all files from
+  // the previous build are still tracked.
+  const inputFileVersions: Map<string, string> = new Map(oldBuildInfo?.inputFileVersions);
 
   const buildInfo: IIncrementalBuildInfo = {
     configHash,

diff --git a/common/changes/@rushstack/heft/copy-file-watch_2024-09-30-20-22.json b/common/changes/@rushstack/heft/copy-file-watch_2024-09-30-20-22.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft",
+      "comment": "Include all previous `inputFileVersions` in incremental copy files cache file during watch mode. Fix incorrect serialization of cache file for file copy.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/heft"
+}