-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js/webgpu] Support Reshape/Shape 21+ on jsep #21871
Conversation
@guschmue @fs-eire @satyajandhyala Please take a look, thanks. |
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline |
/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline |
/azp run Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline |
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
thank you for the fix! there are 2 work items can be the next step:
|
I just wrote a script to compare WebGPU and CPU ops (script is uploaded as #21879, not for merge). A better way should compare WebGPU and ONNX, but I need more time to explore. I put results in different categories (2147483647 means +), attached with some comments. Your suggestions are welcome! [WebGPU EP needs fixes] // PR is needed [multiple domains] // I think we're fine not to support com.microsoft domain [Old version ranges are not implemented] // I suppose we're OK not to support old definitions [CPU has more version ranges] // Are we fine with this? [WebGPU has more version ranges] // We should be fine to support more ranges in WebGPU |
The script helped a lot for reducing the complete operator list to a reasonable length. May need a manual review for the operators on the list. |
Description
#21618
With this PR, the cross device copying (
MemcpyToHost
) can totally be removed for modelwav2vec2
. And the overall time becomes 48ms from 604ms.Motivation and Context