Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Added ZRANGESTORE command #826

Merged
merged 15 commits into from
Dec 8, 2024
Merged

[Compatibility] Added ZRANGESTORE command #826

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e055f42
WIP of ZRANGESTORE
Vijay-Nirmal Nov 23, 2024
d26ca19
Merge branch 'main' into new/ZRANGESTORE-command
Vijay-Nirmal Nov 24, 2024
926f278
Final changes
Vijay-Nirmal Nov 24, 2024
db7db2e
Merge branch 'main' into new/ZRANGESTORE-command
Vijay-Nirmal Nov 24, 2024
aea3891
Added ACL test
Vijay-Nirmal Nov 24, 2024
2c65e26
Removed temp code
Vijay-Nirmal Nov 24, 2024
376b256
Removed TODO command
Vijay-Nirmal Nov 24, 2024
1d8216f
Slot Test
Vijay-Nirmal Nov 25, 2024
dd426e4
Merge branch 'main' into new/ZRANGESTORE-command
Vijay-Nirmal Nov 26, 2024
a027004
Merge branch 'main' into new/ZRANGESTORE-command
Vijay-Nirmal Nov 27, 2024
91915e0
Merge branch 'main' into new/ZRANGESTORE-command
Vijay-Nirmal Nov 28, 2024
c86d1f8
Merge latest
Vijay-Nirmal Dec 5, 2024
20ac282
Review command fix
Vijay-Nirmal Dec 5, 2024
98e1b86
Merge branch 'main' into new/ZRANGESTORE-command
Vijay-Nirmal Dec 7, 2024
4295c1e
Merge branch 'main' into new/ZRANGESTORE-command
Vijay-Nirmal Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Slot Test
  • Loading branch information
@Vijay-Nirmal
Vijay-Nirmal committed Nov 25, 2024
commit 1d8216fec3ef52b20f136f9637dbe4ed208a2dce
29 changes: 29 additions & 0 deletions test/Garnet.test.cluster/RedirectTests/BaseCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1921,6 +1921,35 @@ public override ArraySegment<string>[] SetupSingleSlotRequest()
}
}

internal class ZRANGESTORE : BaseCommand
{
public override bool IsArrayCommand => true;
public override bool ArrayResponse => false;
public override string Command => nameof(ZRANGESTORE);

public override string[] GetSingleSlotRequest()
{
var ssk = GetSingleSlotKeys;
// ZRANGESTORE dst src 0 -1
return [ssk[0], ssk[1], "0", "-1"];
}

public override string[] GetCrossSlotRequest()
{
var csk = GetCrossSlotKeys;
return [csk[0], csk[1], "0", "-1"];
}

public override ArraySegment<string>[] SetupSingleSlotRequest()
{
var ssk = GetSingleSlotKeys;
var setup = new ArraySegment<string>[2];
setup[0] = new(["ZADD", ssk[1], "1", "a", "2", "b", "3", "c"]);
setup[1] = new(["ZADD", ssk[2], "4", "d", "5", "e", "6", "f"]);
return setup;
}
}

#endregion

#region HashCommands
Expand Down
7 changes: 7 additions & 0 deletions test/Garnet.test.cluster/RedirectTests/ClusterSlotVerificationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public class ClusterSlotVerificationTests
new ZREM(),
new ZCARD(),
new ZRANGE(),
new ZRANGESTORE(),
new ZSCORE(),
new ZMSCORE(),
new ZPOPMAX(),
Expand Down Expand Up @@ -274,6 +275,7 @@ public virtual void OneTimeTearDown()
[TestCase("ZREM")]
[TestCase("ZCARD")]
[TestCase("ZRANGE")]
[TestCase("ZRANGESTORE")]
[TestCase("ZSCORE")]
[TestCase("ZMSCORE")]
[TestCase("ZPOPMAX")]
Expand Down Expand Up @@ -413,6 +415,7 @@ void GarnetClientSessionClusterDown(BaseCommand command)
[TestCase("ZREM")]
[TestCase("ZCARD")]
[TestCase("ZRANGE")]
[TestCase("ZRANGESTORE")]
[TestCase("ZSCORE")]
[TestCase("ZMSCORE")]
[TestCase("ZPOPMAX")]
Expand Down Expand Up @@ -562,6 +565,7 @@ void GarnetClientSessionOK(BaseCommand command)
[TestCase("ZREM")]
[TestCase("ZCARD")]
[TestCase("ZRANGE")]
[TestCase("ZRANGESTORE")]
[TestCase("ZSCORE")]
[TestCase("ZMSCORE")]
[TestCase("ZPOPMAX")]
Expand Down Expand Up @@ -703,6 +707,7 @@ void GarnetClientSessionCrossslotTest(BaseCommand command)
[TestCase("ZREM")]
[TestCase("ZCARD")]
[TestCase("ZRANGE")]
[TestCase("ZRANGESTORE")]
[TestCase("ZSCORE")]
[TestCase("ZMSCORE")]
[TestCase("ZPOPMAX")]
Expand Down Expand Up @@ -851,6 +856,7 @@ void GarnetClientSessionMOVEDTest(BaseCommand command)
[TestCase("ZREM")]
[TestCase("ZCARD")]
[TestCase("ZRANGE")]
[TestCase("ZRANGESTORE")]
[TestCase("ZSCORE")]
[TestCase("ZMSCORE")]
[TestCase("ZPOPMAX")]
Expand Down Expand Up @@ -1016,6 +1022,7 @@ void GarnetClientSessionASKTest(BaseCommand command)
[TestCase("ZREM")]
[TestCase("ZCARD")]
[TestCase("ZRANGE")]
[TestCase("ZRANGESTORE")]
[TestCase("ZSCORE")]
[TestCase("ZMSCORE")]
[TestCase("ZPOPMAX")]
Expand Down