Set up the commit comment for BDN as well as summary to show current …

…vs previous BDN perf numbers
microsoft · darrenge · Dec 11, 2024 · Sep 9, 2024 · Sep 9, 2024 · Sep 9, 2024
commit 68d0972ccb4255528d1174fb769ee0270d599155
@@ -8,7 +8,7 @@ env:
 
 permissions:
   actions: write
-  deployments: write  # permission to deploy GitHub pages website
+  deployments: write  #permission to deploy GitHub pages website
   contents: write  # permission to update benchmark contents in gh-pages branch
 
 jobs:
@@ -62,6 +62,7 @@ jobs:
           path: |
              ./test/BDNPerfTests/results
         if: ${{ always() }}
+
       - name: Upload Error Log to artifacts
         uses: actions/upload-artifact@v4
         with:
@@ -81,27 +82,24 @@ jobs:
       - name: Store benchmark result for commit comment
         uses: benchmark-action/github-action-benchmark@v1
         with:
-          # What benchmark tool created output file
           tool: 'benchmarkdotnet'
-
-          # Need for both commit comment and charts
           output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json
           github-token: ${{ secrets.GITHUB_TOKEN }}
-
+          alert-threshold: '200%' 
           external-data-json-path: ./cache/benchmark-data.json
-          fail-on-alert: true
           comment-on-alert: true
-          summary-always: true
-          auto-push: false
+          fail-on-alert: true
+          alert-comment-cc-users: '@darrenge'
+          summary-always: false
+          auto-push: false  # needs to be false if using external-data-json-path
 
       # Run `github-action-benchmark` action
       - name: Store benchmark result for charts
         uses: benchmark-action/github-action-benchmark@v1
         with:
-          # What benchmark tool created output file
+          name: BDNBenchmark - ${{matrix.test}} (os ${{matrix.os}}, framework ${{matrix.framework}}, configuration ${{matrix.configuration}})
           tool: 'benchmarkdotnet'
-
-          # Need for both commit comment and charts
           output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json
           github-token: ${{ secrets.GITHUB_TOKEN }}
+          summary-always: true
           auto-push: true
diff --git a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespLuaRunnerStress.json b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespLuaRunnerStress.json
@@ -3,7 +3,7 @@
     "framework": "net8.0",
     "filter": "*LuaRunner*",
     "expectedBasicLuaRunner1MeanValue_linux": 182,
-    "expectedBasicLuaRunner2MeanValue_linux": 301,
+    "expectedBasicLuaRunner2MeanValue_linux": 325,
     "expectedBasicLuaRunner3MeanValue_linux": 1473,
     "expectedBasicLuaRunner4MeanValue_linux": 3754,
 

diff --git a/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespLuaStress.json b/test/BDNPerfTests/ConfigFiles/CI_BDN_Config_Resp.RespLuaStress.json
@@ -7,6 +7,7 @@
     "expectedBasicLuaStress2MeanValue_linux": 284,
     "expectedBasicLuaStress3MeanValue_linux": 1407,
     "expectedBasicLuaStress4MeanValue_linux": 2733,
+
     "expectedBasicLuaStress1AllocatedValue_linux": 24,
     "expectedBasicLuaStress2AllocatedValue_linux": 144,
     "expectedBasicLuaStress3AllocatedValue_linux": 328,
@@ -16,6 +17,7 @@
     "expectedBasicLuaStress2MeanValue_win": 180,
     "expectedBasicLuaStress3MeanValue_win": 660,
     "expectedBasicLuaStress4MeanValue_win": 1805,
+
     "expectedBasicLuaStress1AllocatedValue_win": 24,
     "expectedBasicLuaStress2AllocatedValue_win": 144,
     "expectedBasicLuaStress3AllocatedValue_win": 328,