Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-charting): add functionality to export chart as image #33445

Merged
merged 16 commits into from
Dec 23, 2024
Merged

feat(react-charting): add functionality to export chart as image #33445

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6a2f26c
add svgToPng helper function
krkshitij Dec 11, 2024
13b0f58
make css inline to svg
krkshitij Dec 11, 2024
d40af4a
Merge branch 'master' of https://github.com/microsoft/fluentui into d…
krkshitij Dec 13, 2024
be6537f
clone legends to svg
krkshitij Dec 16, 2024
d2eb3ac
enable export as image functionality for all charts
krkshitij Dec 17, 2024
4f20fc3
Merge branch 'master' of https://github.com/microsoft/fluentui into d…
krkshitij Dec 17, 2024
efd49b4
add change file
krkshitij Dec 17, 2024
585c544
refactor
krkshitij Dec 20, 2024
21848d4
fix errors
krkshitij Dec 20, 2024
d4bf189
add comments
krkshitij Dec 20, 2024
5390201
update api
krkshitij Dec 20, 2024
1d43e84
resolve review comments
krkshitij Dec 20, 2024
7a0f86d
use ref to cartesian chart instead of componentRef
krkshitij Dec 21, 2024
de674df
Merge branch 'master' of https://github.com/microsoft/fluentui into d…
krkshitij Dec 21, 2024
5b2ce3d
add interface for cartesian chart
krkshitij Dec 22, 2024
4215b1f
use the same IChart interface for cartesian chart
krkshitij Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix errors
  • Loading branch information
@krkshitij
krkshitij committed Dec 20, 2024
commit 21848d499be828d6ffae74f407dfec2427a1a8c4
7 changes: 5 additions & 2 deletions packages/charts/react-charting/src/components/CommonComponents/CartesianChart.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {
} from '../../utilities/index';
import { LegendShape, Shape } from '../Legends/index';
import { SVGTooltipText } from '../../utilities/SVGTooltipText';
import {IChart} from '../../types/index'
import { IChart } from '../../types/index';

const getClassNames = classNamesFunction<ICartesianChartStyleProps, ICartesianChartStyles>();
const ChartHoverCard = React.lazy(() =>
Expand Down Expand Up @@ -64,7 +64,10 @@ export interface ICartesianChartState {
* 2.Callout
* 3.Fit parent Continer
*/
export class CartesianChartBase extends React.Component<IModifiedCartesianChartProps, ICartesianChartState>implements IChart {
export class CartesianChartBase
extends React.Component<IModifiedCartesianChartProps, ICartesianChartState>
implements IChart
{
private _classNames: IProcessedStyleSet<ICartesianChartStyles>;
private chartContainer: HTMLDivElement;
private legendContainer: HTMLDivElement;
Expand Down
Loading