Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

BotDependencyConfiguration defines ExecutorService bean but its not in use #1339

Open
@przem

Description

Is your feature request related to a problem? Please describe.
The problem i've stumbled upon is that i was getting com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 date/time type `java.time.OffsetDateTime` not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling (through reference chain: com.microsoft.bot.schema.Activity["timestamp"]) error for missing module that was already in the deps. The cause was that ExecutorFactory#factory was using wrong classloader and module was not there. Had to do nasty reflection tricks to exchange the factory.

Describe the solution you'd like
I'd like that BotFrameworkAdapter utilize the ExecutorService spring bean. This could be done by expanding constructor of BotFrameworkAdapter to accept ExecutorService, and also other classes like BotFrameworkHttpAdapter AdapterWithErrorHandler

Metadata

Assignees

No one assigned

    Labels

    Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.customer-reportedIssue is created by anyone that is not a collaborator in the repository.feature-requestA request for new functionality or an enhancement to an existing one.needs-triageThe issue has just been created and it has not been reviewed by the team.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions