Fix test script overwriting grep option #8209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // {{SQL CARBON EDIT}} | ||
| // Set test run options. These are NOT used if grep is specified manually - that implies the user has a specific desire to | ||
| // filter the tests beyond the defaults set for ADS_TEST_GREP in the calling scripts. | ||
| if (!argv.grep) { |
There was a problem hiding this comment.
I generally use -g instead of --grep.
There was a problem hiding this comment.
Nvm i see its decribed above as both
There was a problem hiding this comment.
Yeah I tested this with -g so this should be working as intended with both 😄
aaomidi
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8199