Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] raise more informative error for duplicates in 'machines' (fixes #4057) #4059

Merged
merged 4 commits into from
Mar 10, 2021
Merged

[dask] raise more informative error for duplicates in 'machines' (fixes #4057) #4059

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
272f97c
[dask] raise more informative error for duplicates in 'machines'
jameslamb Mar 10, 2021
39359c7
uncomment
jameslamb Mar 10, 2021
9442bdf
avoid test failure
jameslamb Mar 10, 2021
91de707
Revert "avoid test failure"
jameslamb Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "avoid test failure" 
This reverts commit 9442bdf.
  • Loading branch information
@jameslamb
jameslamb committed Mar 10, 2021
commit 91de7075f93546137bfc160e9c688d8185ad1b25
6 changes: 1 addition & 5 deletions tests/python_package_test/test_dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,11 +1057,7 @@ def test_network_params_not_required_but_respected_if_given(client, task, output

# model 2 - machines given
n_workers = len(client.scheduler_info()['workers'])
while True:
open_ports = [lgb.dask._find_random_open_port() for _ in range(n_workers)]
if len(set(open_ports)) == len(open_ports):
break

open_ports = [lgb.dask._find_random_open_port() for _ in range(n_workers)]
dask_model2 = dask_model_factory(
n_estimators=5,
num_leaves=5,
Expand Down