Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWIG methods that return char** #2850

Merged
merged 7 commits into from
Mar 20, 2020
Merged

Fix SWIG methods that return char** #2850

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be17707
[swig] Fix SWIG methods that return char** with StringArray.
Feb 23, 2020
2746c72
Changes to C API and wrappers support char**
Mar 14, 2020
b461881
Cleanup indentation in new lightgbm_R.cpp code
Mar 14, 2020
935947b
Adress review code-style comments.
AlbertoEAF Mar 18, 2020
0c4f1fe
Update swig/StringArray.hpp
AlbertoEAF Mar 18, 2020
4496080
Update python-package/lightgbm/basic.py
AlbertoEAF Mar 19, 2020
9873427
Update src/lightgbm_R.cpp
AlbertoEAF Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/lightgbm_R.cpp 
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>
  • Loading branch information
@AlbertoEAF @StrikerRUS
AlbertoEAF and StrikerRUS authored Mar 19, 2020
commit 9873427842bf5b37760ad275f575e271294898f9
3 changes: 1 addition & 2 deletions src/lightgbm_R.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,7 @@ LGBM_SE LGBM_BoosterGetEvalNames_R(LGBM_SE handle,
R_GET_PTR(handle),
len, &out_len,
reserved_string_size, &required_string_size,
ptr_names.data()
));
ptr_names.data()));
CHECK_EQ(out_len, len);
CHECK_GE(reserved_string_size, required_string_size);
auto merge_names = Common::Join<char*>(ptr_names, "\t");
Expand Down