Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine config object #1381

Merged
merged 21 commits into from
May 20, 2018
Merged

Refine config object #1381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e669626
[WIP] refine config
guolinke May 19, 2018
3c0202b
[wip] ready for the auto code generate
guolinke May 19, 2018
0b24d99
auto generate config codes
guolinke May 19, 2018
b5f89c1
use with to open file
guolinke May 19, 2018
54beb87
fix bug
guolinke May 19, 2018
489c329
fix pylint
guolinke May 19, 2018
ef71f40
fix bug
guolinke May 19, 2018
cedffc1
fix pylint
guolinke May 19, 2018
b94ccd7
fix bugs.
guolinke May 19, 2018
cf5c98a
tmp for failed test.
guolinke May 19, 2018
d03574b
fix tests.
guolinke May 19, 2018
81f546a
added nthreads alias
StrikerRUS May 19, 2018
274e4d6
added new aliases from new config.h
StrikerRUS May 19, 2018
7b330e7
fixed duplicated alias
StrikerRUS May 19, 2018
c0009ee
refactored parameter_generator.py
StrikerRUS May 19, 2018
5e15340
added new aliases from config.h and removed remaining old names
StrikerRUS May 20, 2018
374b7c7
fix bugs & some miss alias
guolinke May 20, 2018
165b06c
added aliases
StrikerRUS May 20, 2018
fa2a9c8
Merge remote-tracking branch 'origin/save-parameter' into save-parameter
StrikerRUS May 20, 2018
a789c19
add more descriptions.
guolinke May 20, 2018
4e491cd
add comment.
guolinke May 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[WIP] refine config
  • Loading branch information
@guolinke
guolinke committed May 19, 2018
commit e66962694b949d6707dc29890c3b4829020417b3
2 changes: 1 addition & 1 deletion include/LightGBM/application.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class Application {
void ConvertModel();

/*! \brief All configs */
OverallConfig config_;
Config config_;
/*! \brief Training data */
std::unique_ptr<Dataset> train_data_;
/*! \brief Validation data */
Expand Down
4 changes: 2 additions & 2 deletions include/LightGBM/boosting.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class LIGHTGBM_EXPORT Boosting {
* \param training_metrics Training metric
*/
virtual void Init(
const BoostingConfig* config,
const Config* config,
const Dataset* train_data,
const ObjectiveFunction* objective_function,
const std::vector<const Metric*>& training_metrics) = 0;
Expand All @@ -47,7 +47,7 @@ class LIGHTGBM_EXPORT Boosting {
virtual void ResetTrainingData(const Dataset* train_data, const ObjectiveFunction* objective_function,
const std::vector<const Metric*>& training_metrics) = 0;

virtual void ResetConfig(const BoostingConfig* config) = 0;
virtual void ResetConfig(const Config* config) = 0;



Expand Down
Loading