[fix] resolve potential attack in linker connection building (#6752)

microsoft · Dec 14, 2024 · b33a12e · b33a12e · dance-cmdr · Jan 7, 2025
1 parent 53e0ddf
commit b33a12e
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/network/linkers_socket.cpp b/src/network/linkers_socket.cpp
@@ -157,6 +157,9 @@ void Linkers::ListenThread(int incoming_cnt) {
     }
     int* ptr_in_rank = reinterpret_cast<int*>(buffer);
     int in_rank = *ptr_in_rank;
+    if (in_rank < 0 || in_rank >= num_machines_) {
+      Log::Fatal("Invalid rank %d found during initialization of linkers. The world size is %d.", in_rank, num_machines_);
+    }
     // add new socket
     SetLinker(in_rank, handler);
     ++connected_cnt;