Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocm warp size fix #5402

Merged
merged 9 commits into from
May 17, 2024
Merged

Rocm warp size fix #5402

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
02f0e39
Warp_size issue fix on ROCm for JIT builds
rraminen Mar 19, 2024
cc8922f
Warp_size issue fix on ROCm for non-JIT builds
rraminen Mar 20, 2024
8229706
Set default value of rocm_wavefront_size to 32
rraminen Mar 22, 2024
5d0e1c6
Added comments
rraminen Mar 22, 2024
88c7be4
Support on all AMD GPUs
rraminen Apr 11, 2024
c87c4f3
Formatting fix
Apr 18, 2024
fa9aa86
Merge branch 'master' into rocm_warp_size_fix
loadams May 16, 2024
caf80f3
Merge branch 'master' into rocm_warp_size_fix
loadams May 17, 2024
25e7f75
For random_ltd build on NAVI3x
rraminen May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set default value of rocm_wavefront_size to 32
  • Loading branch information
@rraminen
rraminen committed May 14, 2024
commit 8229706edf582a6ff8f1d3e14bfd1c87cd92f7cd
2 changes: 1 addition & 1 deletion op_builder/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def get_rocm_wavefront_size():
result = subprocess.check_output(rocm_wavefront_size_cmd, shell=True)
rocm_wavefront_size = result.decode('utf-8').strip()
except subprocess.CalledProcessError:
rocm_wavefront_size = "default"
rocm_wavefront_size = "32"
OpBuilder._rocm_wavefront_size = rocm_wavefront_size
return OpBuilder._rocm_wavefront_size

Expand Down