Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parse+tests for audio, video, and source elements. #65

Merged
merged 1 commit into from
May 29, 2015
Merged

Added parse+tests for audio, video, and source elements. #65

merged 1 commit into from
May 29, 2015

Conversation

gRegorLove
Copy link
Member

Fixes #63, reference http://microformats.org/wiki/microformats-2-parsing#parsing_a_u-_property

Note: Test UrlTest::testReturnsUrlIfAbsolute was failing and continues to fail (PHP 5.4):

Mf2\Parser\Test\UrlTest::testReturnsUrlIfAbsolute with data set #16 ('relative add scheme host user from base', 'http://user:@www.example.com', 'server.php', 'http://user:@www.example.com/server.php')
relative add scheme host user from base
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'http://user:@www.example.com/server.php'
+'http://user@www.example.com/server.php'

kylewm added a commit that referenced this pull request May 29, 2015
@kylewm
Merge pull request #65 from gRegorLove/develop2
28fd812 
Added parse+tests for audio, video, and source elements.
@kylewm kylewm merged commit 28fd812 into microformats:master May 29, 2015
@gRegorLove gRegorLove deleted the develop2 branch May 30, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse u-audio
2 participants
@gRegorLove @kylewm