Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2: fix dynamic property #263

Merged
merged 1 commit into from
Sep 30, 2024
Merged

PHP 8.2: fix dynamic property #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PHP 8.2: fix dynamic property 
Looks like the `Parser::$stringDateTimes` property was removed in commit 7895e56, which was part of the `0.2.0` release, so setting this non-declared property from the tests has no function.

Removing the property setting fixes the PHP 8.2 "Creation of dynamic property Mf2\Parser::$stringDateTimes is deprecated" deprecation notices.
  • Loading branch information
@jrfnl
jrfnl committed Sep 12, 2024
commit 481e4aafd6cfe745ceeb091c0f630e6d8853092d
3 changes: 0 additions & 3 deletions tests/Mf2/CombinedMicroformatsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ public function testHEventLocationHCard() {
}';

$parser = new Parser($input, '', true);
$parser->stringDateTimes = true;
$output = $parser->parse();

$this->assertJsonStringEqualsJsonString(json_encode($output), $expected);
Expand Down Expand Up @@ -96,7 +95,6 @@ public function testHCardOrgPOrg() {
}';

$parser = new Parser($input, '', true);
$parser->stringDateTimes = true;
$output = $parser->parse();

$this->assertJsonStringEqualsJsonString(json_encode($output), $expected);
Expand Down Expand Up @@ -135,7 +133,6 @@ public function testHCardOrgHCard() {
}';

$parser = new Parser($input, '', true);
$parser->stringDateTimes = true;
$output = $parser->parse();

$this->assertJsonStringEqualsJsonString(json_encode($output), $expected);
Expand Down
Loading