You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Curl does not automatically support any compression. This is problematic as it also does not send an Accept-Encoding header. Note that not sending the header at all suggests to the server that any encoding is fine, and they are free to respond with a compressed format. It looks like most will not do this though, or this would have come up before.
I think we have two clear options:
Specify a specific Accept-Encoding value of identity, which should tell servers never to send compressed data; or
defining CURLOPT_ENCODING to automatically have Curl handle the compressions it knows about (DEFLATE and gzip):
curl_setopt($ch, CURLOPT_ENCODING, '');
The text was updated successfully, but these errors were encountered:
Alternatively I wonder if we should offload this to an external dependency. Maybe even aaronpk/p3k-http. That way all those weird extra flags we need for HTTP/2, gzip, etc., only need to get added once and multiple projects will profit from it.
One of the goals of this library is to be self-contained so that it can be included in other projects without bringing in a lot of other dependencies. I think it's best to just add this flag here rather than bring in p3k-http or any other http client.
This became clear when inspecting indieweb/indiewebify-me#78.
Curl does not automatically support any compression. This is problematic as it also does not send an
Accept-Encoding
header. Note that not sending the header at all suggests to the server that any encoding is fine, and they are free to respond with a compressed format. It looks like most will not do this though, or this would have come up before.I think we have two clear options:
Specify a specific
Accept-Encoding
value ofidentity
, which should tell servers never to send compressed data; ordefining
CURLOPT_ENCODING
to automatically have Curl handle the compressions it knows about (DEFLATE and gzip):The text was updated successfully, but these errors were encountered: