Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #12704 - integrate configCmd into startCmd #13157
base: master
Are you sure you want to change the base?
Fix: #12704 - integrate configCmd into startCmd #13157
Changes from 1 commit
b261ef3
dc95117
94c8187
e8329d0
874d22c
f8806dc
6bf8cd0
081defc
c15ee82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 56 in mesheryctl/internal/cli/root/system/start.go
GitHub Actions / golangci-lint (1.23, ubuntu-22.04)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you check if there is an existing Meskit error or implement one here, there is already example in error.go file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lekaf974 Can this error be used here? It's mentioned in the error.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum I think yes since it looks to be related to kubenertes context, can you check in the code where it is used to validate ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lekaf974 , the error code is -
mesheryctl-1068
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not ok ref https://docs.meshery.io/reference/mesheryctl/system/context
Check failure on line 107 in mesheryctl/internal/cli/root/system/start.go
GitHub Actions / golangci-lint (1.23, ubuntu-22.04)
Check failure on line 137 in mesheryctl/internal/cli/root/system/start.go
GitHub Actions / golangci-lint (1.23, ubuntu-22.04)
Check failure on line 207 in mesheryctl/internal/cli/root/system/start.go
GitHub Actions / golangci-lint (1.23, ubuntu-22.04)
Check failure on line 277 in mesheryctl/internal/cli/root/system/start.go
GitHub Actions / golangci-lint (1.23, ubuntu-22.04)