Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #12704 - integrate configCmd into startCmd #13157

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix: #12704 - integrate configCmd into startCmd #13157

wants to merge 2 commits into from

Conversation

yaten2302
Copy link
Contributor

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.
  1. This PR integrates mesheryctl system config minikube|eks|aks|gke command into mesheryctl system start command.
  2. This PR also, takes into account the login behavior, if the user isn't logged in and is attempting to configurate the kubernetes cluster used by Meshery, then the user must login first and then move furthur.

attempt to integrate configCmd into startCmd
b261ef3 
Signed-off-by: yaten2302 <yaten2302@gmail.com>
@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label Jan 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025 •
edited
Loading

View in catalog, Edit in playground or learn how to interpret Meshery Designs

@yaten2302 yaten2302 changed the title Fix: #12704 - attempt to integrate configCmd into startCmd Fix: #12704 - integrate configCmd into startCmd Jan 5, 2025
@vishalvivekm
Copy link
Contributor

@yaten2302
Thank you for your contributions! Let's discuss this today, during Meshery Development call at 9:00 AM CT | 8:30 PM IST. Adding it as an agenda item to the meeting minutes || meeting link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/mesheryctl CLI for Meshery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mesheryctl] mesheryctl system config minikube command workflow
2 participants
@yaten2302 @vishalvivekm