Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Operator] Fix Ping Test for Clusters Without Deployed Meshery Operator #12849

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[Operator] Fix Ping Test for Clusters Without Deployed Meshery Operator #12849

wants to merge 9 commits into from

Conversation

yash37158
Copy link
Member

Notes for Reviewers
Fix Ping Test Succeeding for Clusters Without Meshery Operator.

This pull request resolves an issue where the "Ping Operator" test incorrectly succeeds for clusters without a deployed Meshery operator.
Screenshot 2024-12-06 at 1 16 17 AM

Signed commits

  • Yes, I signed my commits.

@yash37158
[Operator] Fix Ping Test for Clusters Without Deployed Meshery Operator
7d62113 
Signed-off-by: yash37158 <yash37158@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label Dec 5, 2024
@yash37158 yash37158 requested a review from Alero-Awani December 5, 2024 20:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

View in catalog, Edit in playground or learn how to interpret Meshery Designs

@yash37158 yash37158 temporarily deployed to staging-playground December 5, 2024 20:47 — with GitHub Actions Inactive
@yash37158 yash37158 requested a review from leecalcote December 6, 2024 10:10
@yash37158 yash37158 temporarily deployed to staging-playground December 6, 2024 18:53 — with GitHub Actions Inactive
@yash37158
Copy link
Member Author

@Alero-Awani, could you let me know if the changes look good to you? I’m looking forward to your valuable feedback!

@vishalvivekm
Copy link
Contributor

@yash37158
Let's discuss this during the Meshery Development call today at 9:00 AM CT | 8:30 PM IST. Adding it as an agenda item to the meeting minutes || meeting link.

@jamieplu
Copy link
Contributor

Is @Alero-Awani reviewing?

@yash37158 yash37158 temporarily deployed to staging-playground December 30, 2024 09:00 — with GitHub Actions Inactive
@yash37158
Copy link
Member Author

@leecalcote @sudhanshutech @Alero-Awani I'm looking for your review on this PR, as it requires only a small change to be finalized. Let me know if it’s already under review or if I should address anything specific to expedite the process.

@yash37158 yash37158 temporarily deployed to staging-playground January 2, 2025 10:46 — with GitHub Actions Inactive
@yash37158 yash37158 temporarily deployed to staging-playground January 3, 2025 07:47 — with GitHub Actions Inactive
@yash37158 yash37158 temporarily deployed to staging-playground January 3, 2025 21:08 — with GitHub Actions Inactive
leecalcote
leecalcote reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yash37158 this doesn't seem like it addresses the root cause of the issue. How is the ping test succeeding in the first place, if the Operator is not deployed?

@leecalcote leecalcote requested review from leecalcote and removed request for Alero-Awani January 3, 2025 21:27
@yash37158 yash37158 temporarily deployed to staging-playground January 7, 2025 14:08 — with GitHub Actions Inactive
@yash37158
Copy link
Member Author

I agree @leecalcote that the root cause is because the ping test is succeeding, but the Operator has not been deployed. Perhaps fade the operator chip or show a status of the Operator is not deployed. This would help to make the issue more obvious to the user. Alternatively, we might add an even more explicit check in the system that makes it impossible for the ping test to succeed unless the Operator is actually deployed. In this way, we ensure that the expected state of the system and the result of the tests are consistent with each other. I'm more than happy to hear any further suggestions or ideas you may have to make things better.

@yash37158 yash37158 temporarily deployed to staging-playground January 8, 2025 19:28 — with GitHub Actions Inactive
@yash37158 yash37158 deployed to staging-playground January 9, 2025 18:58 — with GitHub Actions Active
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

END-TO-END TESTS

  • Testing started at: January 9th 2025, 7:04:33 pm

📦 Test Result Summary

  • ✅ 29 passed
  • ❌ 2 failed
  • ⚠️ 9 flaked
  • ⏩ 0 skipped

⌛ Duration: 7 minutes and 23 seconds

Overall Result: 👎 Some tests failed.

[Show/Hide] Test Result Details
Test Browser Test Case Tags Result
1 chromium-meshery-provider Compare test of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
2 chromium-meshery-provider Delete a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
3 chromium-local-provider Add a cluster connection by uploading kubeconfig file unstable ⚠️
4 chromium-local-provider Transition to disconnected state and then back to connected state unstable ⚠️
5 chromium-local-provider Transition to ignored state and then back to connected state unstable ⚠️
6 chromium-local-provider Transition to not found state and then back to connected state unstable ⚠️
7 chromium-local-provider Delete Kubernetes cluster connections unstable ⚠️
8 chromium-local-provider View detailed result of a performance profile (Graph Visualiser) with load generator "fortio" and service mesh "None" unstable ⚠️
9 chromium-local-provider Edit the configuration of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
10 chromium-local-provider Compare test of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
11 chromium-local-provider Delete a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
12 chromium-local-provider Aggregation Charts are displayed ❌
13 chromium-local-provider Connect to Meshery Istio Adapter and configure it ❌
14 chromium-local-provider Toggle "Send Anonymous Usage Statistics" unstable ⚠️
15 chromium-local-provider Toggle "Send Anonymous Performance Results" unstable ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote Awaiting requested review from leecalcote

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component/ui User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Operator] Ping Test Succeeds for Clusters Without Meshery Operator
4 participants
@yash37158 @vishalvivekm @jamieplu @leecalcote