enhance(server): introduce SERVER_HOST variable #11394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argl
reviewed
Aug 6, 2024
There was a problem hiding this comment.
nit: I would call the variable BIND_ADDRESS or similar, since we are handling ip addresses. Otherwise, good and very handy to have.
There was a problem hiding this comment.
I think SERVER_HOST is more common and intuitive given that we have SERVER_PORT next to it.
argl
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2298.
Problem
Currently, it isn't possible to preview the local dev environment on a different local device, like a smartphone, because the server is only reachable locally.
Solution
Introduce a
SERVER_HOSTenvironment variable that allows accessing the server when setting it to0.0.0.0.How did you test this change?
Ran
SERVER_HOST=0.0.0.0 yarn start:static-serverand verified I can access the server from another device on the local network.