Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tidy] Reduce fonts on KPI-card #951

Merged
merged 11 commits into from
Jan 14, 2025
Merged

[Tidy] Reduce fonts on KPI-card #951

merged 11 commits into from
Jan 14, 2025

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Jan 14, 2025 •
edited
Loading

Description

  • Reduces font-size on KPI card title and KPI card body
  • Removes padding from KPI card
  • Change to rem units (will then react to zoom in/out)

Screenshot

Before (on laptop)
Screenshot 2025-01-14 at 13 05 13

After (on laptop)
Screenshot 2025-01-14 at 13 04 33

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen self-assigned this Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-01-14 13:01:12 UTC
Commit: 42deeb5

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review January 14, 2025 13:17
@huong-li-nguyen
Copy link
Contributor Author

huong-li-nguyen commented Jan 14, 2025 •
edited
Loading

@maxschulz-COL @Joseph-Perkins - can you both please double-check whether the two issues you've raised are fixed by this? :) I can't link the issues here as you've raised them in the internal repository.

petar-qb
petar-qb approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like converting css font sizes to rem units. It's zoom responsive now 🎉

nadijagraca
nadijagraca approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

maxschulz-COL
maxschulz-COL approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING - just what I was hoping for :)

@huong-li-nguyen huong-li-nguyen merged commit 3879cc9 into main Jan 14, 2025
36 checks passed
@huong-li-nguyen huong-li-nguyen deleted the tidy/update-kpi-font-size branch January 14, 2025 15:00
@Joseph-Perkins
Copy link
Contributor

Looks perfect to me! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadijagraca nadijagraca nadijagraca approved these changes

@petar-qb petar-qb petar-qb approved these changes

@maxschulz-COL maxschulz-COL maxschulz-COL approved these changes

@Joseph-Perkins Joseph-Perkins Awaiting requested review from Joseph-Perkins Joseph-Perkins is a code owner

@antonymilne antonymilne Awaiting requested review from antonymilne antonymilne is a code owner

@lingyielia lingyielia Awaiting requested review from lingyielia lingyielia is a code owner

Assignees

@huong-li-nguyen huong-li-nguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huong-li-nguyen @Joseph-Perkins @maxschulz-COL @petar-qb @nadijagraca