chore(build): remove build process from repo #319
Conversation
mittachaitu
force-pushed
the
fix_license
branch
from
921b021 to
fff7044
Compare
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mittachaitu
force-pushed
the
fix_license
branch
from
fff7044 to
981dbaf
Compare
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
| @@ -169,7 +164,7 @@ script: | |||
|
|
|||
| REL_BRANCH=$(echo $(echo "$TRAVIS_TAG" | cut -d'-' -f1 | rev | cut -d'.' -f2- | rev).x$REL_SUFFIX); | |||
|
|
|||
| ./buildscripts/git-release "$REPO_ORG/istgt" "$TRAVIS_TAG" "$REL_BRANCH" || travis_terminate 1; | |||
| ./buildscripts/git-release "$REPO_ORG/libcstor" "$TRAVIS_TAG" "$REL_BRANCH" || travis_terminate 1; | |||
There was a problem hiding this comment.
what is this steps supposed to do? why this change required?
There was a problem hiding this comment.
This will help to trigger the release on the downstream repo from Travis... Since with this PR, images will be built from libcstor after i.e only after completing the libcstor Travis images & code will be pushed to corresponding image repositories and source repositories...
Existing system: Since images are pushed from cstor triggering istgt release from cstor is good(With this PR things will change).
Release flow(For creating release images):
Existing flow: openebs/linux-utils ---> openebs/libcstor ---> openebs/cstor ---> openebs/istgt ....
Updated flow: openebs/linux-utils ---> openebs/cstor ---> openebs/libcstor ---> openebs/istgt ....
There was a problem hiding this comment.
@mittachaitu let us keep the old flow, as libcstor will become the main repo later on (we will probably rename it) which will tag all dependant repo.
There was a problem hiding this comment.
Ok so you mean cstor and istgt will be triggered from libcstor itself(after renaming it).... that makes sense.
Then I no need to raise a PR in openebs/linux-utils cc: @kmova
There was a problem hiding this comment.
I see, we need base image first. We can build everything from libcstor. and cstor will be just a dependency.
There was a problem hiding this comment.
We are building a base image from libcstor itself https://github.com/openebs/libcstor/blob/35c939ccb7473e2674a3fe9877c33cd74115740a/build_image.sh#L120. So can I change it to(Since base and main images is built from libcstor)
--------> openebs/cstor
openebs/linux-utils ---> openebs/libcstor -----> |
--------> openebs/istgt ----> other dependent repos
There was a problem hiding this comment.
@mittachaitu I see a problem. The image should be pushed at last. And since we are now pushing from libcstor, that should be done after build is successful on cstor. So cstor should be tagged first.
The other thing is, we any way build everything from libcstor, so tagging cstor does not serve any purpose. just that we have marked the code for a particular tag.
let us go ahead with the way you did, later on we will decide how can we do that.
There was a problem hiding this comment.
Can I remove the triggering downstream repo from cstor?
There was a problem hiding this comment.
let us go ahead with the way you did, later on we will decide how can we do that.
Ok
There was a problem hiding this comment.
yeah.. triggering builds from cstor can be removed.
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
|
@mittachaitu add the changelog in this PR. |
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
|
this PR and libcstor PR openebs-archive/libcstor#70 are dependent on each other.. so, merging this PR even if the travis is failing |
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io
Pull Request template
Please, go through these steps before you submit a PR. ## Remove this line
Why is this PR required? What issue does it fix?:
This PR is required to incorporate CDDL license comments on cStor repo.
What this PR does?:
This PR does the following changes:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:
Any additional information for your reviewer?:
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>