Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix spurious warning when fetching state after a missing prev event #13258

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Fix spurious warning when fetching state after a missing prev event #13258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d73437a
Fix spurious warning when fetching state after a missing prev event
Jul 12, 2022
ac0702f
Update synapse/handlers/federation_event.py
squahtx Jul 12, 2022
293404c
Update synapse/handlers/federation_event.py
squahtx Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix spurious warning when fetching state after a missing prev event
  • Loading branch information
Sean Quah committed Jul 12, 2022
commit d73437a702405e206d6dd39091fd395e363f3f45
1 change: 1 addition & 0 deletions changelog.d/13258.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix spurious warning when fetching state after a missing prev event.
3 changes: 3 additions & 0 deletions synapse/handlers/federation_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,9 @@ async def _get_state_ids_after_missing_prev_event(
# XXX: this doesn't sound right? it means that we'll end up with incomplete
# state.
failed_to_fetch = desired_events - event_metadata.keys()
# `event_id`'s missing from `event_metadata` because it's not necessarily a
squahtx marked this conversation as resolved.
Show resolved Hide resolved
# state event. We've already checked that we've fetched it above.
failed_to_fetch.discard(event_id)
if failed_to_fetch:
logger.warning(
"Failed to fetch missing state events for %s %s",
Expand Down