Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve ServerNoticeServlet to avoid duplicate requests #10679

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Improve ServerNoticeServlet to avoid duplicate requests #10679

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6bf2d8
Improve ServerNoticeServlet to avoid duplicate
dklimpel Aug 23, 2021
f54b91f
newsfile
dklimpel Aug 23, 2021
e425c00
change `user_id` to `target_user`
dklimpel Aug 26, 2021
aca0930
disable `SendServerNoticeServlet` in workers
dklimpel Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
disable SendServerNoticeServlet in workers
  • Loading branch information
@dklimpel
dklimpel committed Aug 26, 2021
commit aca093003dd3f7b4de864e37d6e8f9f291a606bf
5 changes: 4 additions & 1 deletion synapse/rest/admin/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ def register_servlets(hs: "HomeServer", http_server: HttpServer) -> None:
RoomMembersRestServlet(hs).register(http_server)
DeleteRoomRestServlet(hs).register(http_server)
JoinRoomAliasServlet(hs).register(http_server)
SendServerNoticeServlet(hs).register(http_server)
VersionServlet(hs).register(http_server)
UserAdminServlet(hs).register(http_server)
UserMembershipRestServlet(hs).register(http_server)
Expand All @@ -247,6 +246,10 @@ def register_servlets(hs: "HomeServer", http_server: HttpServer) -> None:
NewRegistrationTokenRestServlet(hs).register(http_server)
RegistrationTokenRestServlet(hs).register(http_server)

# Some servlets only get registered for the main process.
if hs.config.worker_app is None:
SendServerNoticeServlet(hs).register(http_server)


def register_servlets_for_client_rest_resource(
hs: "HomeServer", http_server: HttpServer
Expand Down