Use new `device_lists_changes_in_room` table for fetching device lists in `/sync`

We added a table that tracks device list changes in a room in https://github.com/matrix-org/synapse/pull/12321. We can use this in `/sync` (and `/keys/changes`) to more efficiently calculate the device list changes without having to calculate the full set of users who share a room with the requester.

c.f. 

https://github.com/matrix-org/synapse/blob/573cd0f92f78de54cbe5dc9d0bf9f904f9d90011/synapse/handlers/sync.py#L1313-L1329

and

https://github.com/matrix-org/synapse/blob/573cd0f92f78de54cbe5dc9d0bf9f904f9d90011/synapse/handlers/device.py#L139-L143

The tricky thing is that since the table has been added recently we need to a) only use it once our minimum schema is `69` and b) only for device list stream IDs that have happened after a. 

	users_who_share_room = (
	await self.store.get_users_who_share_room_with_user(user_id)
	)

	# Always tell the user about their own devices. We check as the user
	# ID is almost certainly already included (unless they're not in any
	# rooms) and taking a copy of the set is relatively expensive.
	if user_id not in users_who_share_room:
	users_who_share_room = set(users_who_share_room)
	users_who_share_room.add(user_id)

	tracked_users = users_who_share_room
	users_that_have_changed = (
	await self.store.get_users_whose_devices_changed(
	since_token.device_list_key, tracked_users
	)
	)

	# First we check if any devices have changed for users that we share
	# rooms with.
	users_who_share_room = await self.store.get_users_who_share_room_with_user(
	user_id
	)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use new `device_lists_changes_in_room` table for fetching device lists in `/sync` #12388

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Use new device_lists_changes_in_room table for fetching device lists in /sync #12388

Description