Update contributing.md to warn against rebasing an open PR. (#10563)

Signed-off-by: H.Shay <shaysquared@gmail.com>
matrix-org · Aug 10, 2021 · 52bfa2d · 52bfa2d
1 parent b5de77c
commit 52bfa2d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -252,6 +252,7 @@ To prepare a Pull Request, please:
 4. on GitHub, [create the Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request);
 5. add a [changelog entry](#changelog) and push it to your Pull Request;
 6. for most contributors, that's all - however, if you are a member of the organization `matrix-org`, on GitHub, please request a review from `matrix.org / Synapse Core`.
+7. if you need to update your PR, please avoid rebasing and just add new commits to your branch.
 
 
 ## Changelog

diff --git a/changelog.d/10563.misc b/changelog.d/10563.misc
@@ -0,0 +1 @@
+Update contributing.md to warn against rebasing an open PR.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Update contributing.md to warn against rebasing an open PR.