Add some test

matplotlib · Feb 10, 2024 · 62fe3f4 · 62fe3f4
1 parent 6a8031a
commit 62fe3f4
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 0 deletions.
diff --git a/lib/matplotlib/tests/test_backend_gtk3.py b/lib/matplotlib/tests/test_backend_gtk3.py
@@ -1,7 +1,20 @@
+import os
 from matplotlib import pyplot as plt
 
 import pytest
+from unittest import mock
 
+import gi
+try:
+    # :raises ValueError: If module/version is already loaded, already
+    # required, or unavailable.
+    gi.require_version("Gtk", "3.0")
+except ValueError as e:
+    # in this case we want to re-raise as ImportError so the
+    # auto-backend selection logic correctly skips.
+    raise ImportError(e) from e
+
+from gi.repository import Gtk
 
 pytest.importorskip("matplotlib.backends.backend_gtk3agg")
 
@@ -49,3 +62,20 @@ def receive(event):
     fig.canvas.mpl_connect("draw_event", send)
     fig.canvas.mpl_connect("key_press_event", receive)
     plt.show()
+
+
+@pytest.mark.backend("gtk3agg", skip_on_importerror=True)
+def test_save_figure_return():
+    fig, ax = plt.subplots()
+    ax.imshow([[1]])
+    with mock.patch("gi.repository.Gtk.FileFilter") as fileFilter:
+        filt = fileFilter.return_value
+        filt.get_name.return_value = "Portable Network Graphics"
+        with mock.patch("gi.repository.Gtk.FileChooserDialog") as dialogChooser:
+            dialog = dialogChooser.return_value
+            dialog.get_filter.return_value = filt
+            dialog.get_filename.return_value = "foobar.png"
+            dialog.run.return_value = Gtk.ResponseType.OK
+            fname = fig.canvas.manager.toolbar.save_figure()
+            os.remove("foobar.png")
+            assert fname == "foobar.png"
diff --git a/lib/matplotlib/tests/test_backend_macosx.py b/lib/matplotlib/tests/test_backend_macosx.py
@@ -1,6 +1,7 @@
 import os
 
 import pytest
+from unittest import mock
 
 import matplotlib as mpl
 import matplotlib.pyplot as plt
@@ -44,3 +45,14 @@ def new_choose_save_file(title, directory, filename):
         # Check the savefig.directory rcParam got updated because
         # we added a subdirectory "test"
         assert mpl.rcParams["savefig.directory"] == f"{tmp_path}/test"
+
+
+@pytest.mark.backend('macosx')
+def test_save_figure_return():
+    fig, ax = plt.subplots()
+    ax.imshow([[1]])
+    prop = "matplotlib.backends._macosx.choose_save_file"
+    with mock.patch(prop, return_value="foobar.png"):
+        fname = fig.canvas.manager.toolbar.save_figure()
+        os.remove("foobar.png")
+        assert fname == "foobar.png"
diff --git a/lib/matplotlib/tests/test_backend_qt.py b/lib/matplotlib/tests/test_backend_qt.py
@@ -228,6 +228,17 @@ def test_figureoptions():
         fig.canvas.manager.toolbar.edit_parameters()
 
 
+@pytest.mark.backend('QtAgg', skip_on_importerror=True)
+def test_save_figure_return():
+    fig, ax = plt.subplots()
+    ax.imshow([[1]])
+    prop = "matplotlib.backends.qt_compat.QtWidgets.QFileDialog.getSaveFileName"
+    with mock.patch(prop, return_value=("foobar.png", None)):
+        fname = fig.canvas.manager.toolbar.save_figure()
+        os.remove("foobar.png")
+        assert fname == "foobar.png"
+
+
 @pytest.mark.backend('QtAgg', skip_on_importerror=True)
 def test_figureoptions_with_datetime_axes():
     fig, ax = plt.subplots()