Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel and Group default sizes and bounding dimensions #640

Closed
mathuo opened this issue Jul 11, 2024 · 5 comments · Fixed by #690 or #693
Closed

Panel and Group default sizes and bounding dimensions #640

mathuo opened this issue Jul 11, 2024 · 5 comments · Fixed by #690 or #693
Labels
enhancement New feature or request
Milestone

Comments

@mathuo
Copy link
Owner

mathuo commented Jul 11, 2024

To implement

  • Preferred width and height values for added panels
  • Minimum, maximum width and height values for added panels
  • Explore the idea of priority where certain panels will be offered free space / have space taken from them first/last.
@lupod
Copy link

lupod commented Jul 18, 2024

Not sure if it fits this issue but I'd like to request a change of behaviour when dragging a panel onto another panel to create a group with tabs. Let's look at an example where I have a window that is 1000px wide and three panels A, B, C next to each other. A and C are 100px wide each, and B in the middle takes the remaining 800px.

Current Behaviour:
If I drag C onto A to create a tab group, then as a result both that tab group and B will each have a width of about 500px. This feels unintuitive as both the dragged panel and the target panel had a width of 100px which is much smaller.

Desired Behaviour:
If I drag C onto A to create a tab group, that tab group should remain at the size that A had originally. This feels more like what I'm used to from other software with a dock view layout.

@vincent-lecrubier-skydio

Piece of advice here: Might be worth considering using the Flexbox model directly

@lupod
Copy link

lupod commented Aug 1, 2024

Piece of advice here: Might be worth considering using the Flexbox model directly

Just CSS flex does not give me docking functionality... or do you mean something else?

@mathuo
Copy link
Owner Author

mathuo commented Sep 5, 2024

1.17.1 Releases changes related to initial, maximum and minimum sizes as well as a small change to prevent group resizing when moving groups.

See http://localhost:3000/docs/core/panels/add#minimum-and-maximum

See #708 for continued work on group size preservation

@mathuo mathuo closed this as completed Sep 5, 2024
@amirmamaghani
Copy link
Contributor

minimum and maximum width/height doesn't work on floating windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants