Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to persist fullscreen / maximized mode #494

Closed
garyvh2 opened this issue Feb 7, 2024 · 6 comments · Fixed by #762
Closed

Unable to persist fullscreen / maximized mode #494

garyvh2 opened this issue Feb 7, 2024 · 6 comments · Fixed by #762
Labels
enhancement New feature or request

Comments

@garyvh2
Copy link

garyvh2 commented Feb 7, 2024

Describe the bug
Fullscreen (or maximized) state, is not persisted when calling api.toJSON. Instead this.exitMaximizedView(); is called modifying the end users state.

To Reproduce
Codesandbox example

Screen.Recording.2024-02-07.at.15.44.43.mov

Whenever there's a call to onDidLayoutChange we persist the user's layout state, with toJSON() so we store the layout structure on our end.

When we added the Maximize feature we noticed that the when the user maximizes the group, and changes the active tab, the call to toJSON() executed on onDidLayoutChange causes the maximize state to be lost.

Upon closer inspection on the library we noticed that

dockviewComponent.ts ln.1010 -> this.gridview.serialize() // When the gridview is serialized
   |__ gridview.ts ln.439 -> this.exitMaximizedView() // The library exits the maximized view purposely

Additionally we noticed the comment on

gridview.ts ln.435
/**
 * do not persist maximized view state
 * firstly exit any maximized views to ensure the correct dimensions are persisted
 */

And were wondering if there was a reason for such, we on our end wanted to persist the maximized state, as it's originated from a user interaction, so forcefully removing state is thought as a non expected behavior, but not sure if there was a deeper reason as to not persist such state on your end.

Expected behavior
When the layout is persisted through toJSON method, the maximized state is persisted along the other components.

Screenshots
N/A

Desktop (please complete the following information):

  • Browser all
  • Version all
@gggonzalo
Copy link

This issue is even more evident when the group is maximized but the visible panel is not active. If you click anywhere in the maximized panel (inactive), onDidLayoutChange gets triggered and the maximized state is exited.

Screen.Recording.2024-02-08.at.16.00.42.mov

@mathuo mathuo added the enhancement New feature or request label Feb 29, 2024
@mathuo
Copy link
Owner

mathuo commented Feb 29, 2024

This issue is even more evident when the group is maximized but the visible panel is not active. If you click anywhere in the maximized panel (inactive), onDidLayoutChange gets triggered and the maximized state is exited.

Screen.Recording.2024-02-08.at.16.00.42.mov

This particular issue has been fixed in v1.10.0 - when a group is maximized it's automatically set as the active group

@mathuo
Copy link
Owner

mathuo commented Feb 29, 2024

As for the fullscreen state not being persisted - it would require some non-trival code changes to get to work due the fact of having to store extra metadata in the persisted state.

I agree it's a feature that should exist and will look into it at some point in the near future.

@gggonzalo
Copy link

Hi @mathuo. Is there an update on the maximized state persistence issue? I see v2.0.0. was released recently

@mathuo
Copy link
Owner

mathuo commented Nov 10, 2024 •
edited
Loading

Let me move this up the priority list since it's clearly a wanted feature. I will take a look, recorded here #756

@mathuo mathuo mentioned this issue Nov 10, 2024
Open
@mathuo mathuo linked a pull request Nov 10, 2024 that will close this issue
feat: serialization of maximized views #762
Merged
@mathuo mathuo reopened this Dec 10, 2024
@mathuo
Copy link
Owner

mathuo commented Dec 19, 2024

A working version of this is now released in 2.1.0

@mathuo mathuo closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: serialization of maximized views mathuo/dockview
3 participants
@mathuo @garyvh2 @gggonzalo