Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

MDCRipple: Make resize handler optional for unbounded ripple #4504

Closed
@williamernest

Description

The ripple is supposed to add a resize handler to the window when instantiated with an unbounded ripple. This is currently broken when either programmatically setting the ripple to unbounded by using the setUnbounded function or when setting the ripple to unbounded by using the data-mdc-ripple-is-unbounded attribute. The reason for the latter is the component initialSyncWithDOM function is executed after the foundation registerRootHandlers_ function.

This leads me to believe that we should fix these issues but also make the resize handler optional since it's not absolutely necessary (only necessary when the unbounded ripple is within a dynamically sized container).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Unresolved (Archived)Open and unresolved issues and PRs that were closed due to archiving the repository.backlogtechdebt

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      MDCRipple: Make resize handler optional for unbounded ripple · Issue #4504 · material-components/material-components-web