Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Make MDC Web's TypeScript code work without noStrictGenericChecks: true #4482

Closed
@kfranqueiro

Description

While reviewing #4481 this morning, I finally realized what was preventing us from seeing the errors James encountered in #4463.

noStrictGenericChecks: true is one of the tsconfig settings we inherited while trying to mirror our internal tsconfig as closely as possible. If I remove that setting, we see errors very similar to, if not exactly like, what James was seeing. For example:

image

James has some suggestions on how to fix this, but I'm wondering if we can fix it without needing to e.g. make adapter_ public on foundations...

Metadata

Assignees

No one assigned

    Labels

    Unresolved (Archived)Open and unresolved issues and PRs that were closed due to archiving the repository.iceboxinfrastructure

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions