Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Better document checkbox adapter #3998

Closed
@patrickrodee

Description

hasNativeControl is kind of confusing, since above there's a setNativeControlAttr, which implies there's always a native control. I think this field needs more documentation to explain what information it is conveying, and how that interacts with other things.

Similarly, setNativeControlDisabled probably has implications for the behavior of setNativeControlAttr, please document.

Or maybe it's setting the disabled state of the native control? In which case it definitely needs documentation due to the ambiguity. And then documentation of how this is different from setNattiveControlAttr('disabled')

/** @return {boolean} */
hasNativeControl() {}
/** @param {boolean} disabled */
setNativeControlDisabled(disabled) {}

Metadata

Assignees

No one assigned

    Labels

    Unresolved (Archived)Open and unresolved issues and PRs that were closed due to archiving the repository.backlog

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions