Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE]: develop to release #36

Merged
merged 2 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# 1.23.13

- I had removed the `waitUntil: "networkidle0"` option in a previous release. Based on another package ([minimal-css-test](https://www.npmjs.com/package/minimalcss-test)) I had been working on, I came to the conclusion that this option was not working properly when using puppeteer +20. However, tests seem ok. The purpose of the upgrade is to fix rendering when using [react-helmet](https://www.npmjs.com/package/react-helmet) because I noticed `react-snap-test` is not waiting for [react-helmet](https://www.npmjs.com/package/react-helmet). Hopefully, this release fixes this.
- Add favicon.ico now required by puppeteer (@marcoandre1)

# 1.23.12

Expand Down
Binary file added tests/examples/many-pages/favicon.ico
Binary file not shown.
Binary file added tests/examples/one-page/favicon.ico
Binary file not shown.
Binary file added tests/examples/other/favicon.ico
Binary file not shown.
Binary file added tests/examples/partial/favicon.ico
Binary file not shown.