This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Fix thumbnail generation and update images #395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378
Generating thumbnail images with
npm run create-image
is broken, this appears to stem from #253 due to the change to a.ts
file and the replacement of puppeteer with playwright. In this PR I revert those two changes, and make some additional improvements to the image generation script:map.loaded()
instead of network status. This solves cases where the screenshot would take before the map had loaded. An additional 1.5 second delay ensures that post-loading content (e.g. added images) are captured in the screenshot.npm run create-image
. This is currently crashing due to a puppeteer issue, but generates most of the images. Puppeteer remains in headless mode during this process.Before:
After: