Update JSON Schema Faker (stoplightio#719)

XVincentX · lag-of-death · web-flow · commit 7221ebe9dd77 · 2019-10-21T11:26:39.000+02:00
* chore: upgrade jsf

* docs: changelog

* test: add

* test: with object

* Update CHANGELOG.md

Co-Authored-By: lag-of-death &lt;mateuszwit21@gmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Killing sub-process only if Prism is running in multi-process mode [#645](https://github.com/stoplightio/prism/pull/645)
 - UUIDs are never generated as URNs [#661](https://github.com/stoplightio/prism/pull/661)
 - Core types are now correctly referenced in the HTTP package, restoring the type checks when using the package separately [#701](https://github.com/stoplightio/prism/pull/701)
+- By upgrading Json Schema Faker to the latest version, now the schemas with `additionalProperties:false` / `additionalProperties:true` / `additionalProperties:object` will be correctly handled when dynamic mocking is enabled [#719](https://github.com/stoplightio/prism/pull/719)
 
 # 3.1.1 (2019-09-23)
 
diff --git a/packages/http/package.json b/packages/http/package.json
@@ -16,8 +16,8 @@
     "node": ">=8"
   },
   "dependencies": {
-    "@stoplight/prism-core": "^3.1.1",
     "@stoplight/json-ref-resolver": "^3.0.1",
+    "@stoplight/prism-core": "^3.1.1",
     "@stoplight/ref-resolvers": "^1.0.2",
     "@stoplight/yaml": "^3.0.2",
     "abstract-logging": "^1.0.0",
@@ -27,7 +27,7 @@
     "caseless": "^0.12.0",
     "faker": "^4.1.0",
     "fp-ts": "^2.0.5",
-    "json-schema-faker": "0.5.0-rc21",
+    "json-schema-faker": "0.5.0-rc22",
     "openapi-sampler": "^1.0.0-beta.15",
     "pino": "^5.13.2",
     "tslib": "^1.10.0",
diff --git a/test-harness/specs/dynamic_json_additionalProperties_object.oas3.txt b/test-harness/specs/dynamic_json_additionalProperties_object.oas3.txt
@@ -0,0 +1,32 @@
+====test====
+Prism can generate dynamic responses when the `additionalProperties` schema is set to true
+====spec====
+openapi: 3.0.0
+paths:
+  /resources/{resource_id}:
+    get:
+      responses:
+        '200':
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Resource'
+components:
+  schemas:
+    Resource:
+      type: object
+      properties:
+        name:
+          type: string
+        tags:
+          type: string
+      additionalProperties:
+        type: string
+====server====
+mock -d -p 4010 ${document}
+====command====
+curl -i http://localhost:4010/resources/5 -H "accept: application/json"
+====expect-loose====
+HTTP/1.1 200 OK
+
+{"name": "something","tags": "something else"}
diff --git a/test-harness/specs/dynamic_json_responses_additionalProperties.oas3.txt b/test-harness/specs/dynamic_json_responses_additionalProperties.oas3.txt
@@ -0,0 +1,31 @@
+====test====
+Prism can generate dynamic responses when the `additionalProperties` schema is set to false
+====spec====
+openapi: 3.0.0
+paths:
+  /resources/{resource_id}:
+    get:
+      responses:
+        '200':
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Resource'
+components:
+  schemas:
+    Resource:
+      type: object
+      properties:
+        name:
+          type: string
+        tags:
+          type: string
+      additionalProperties: false
+====server====
+mock -d -p 4010 ${document}
+====command====
+curl -i http://localhost:4010/resources/5 -H "accept: application/json"
+====expect-loose====
+HTTP/1.1 200 OK
+
+{"name": "something","tags": "something else"}
diff --git a/yarn.lock b/yarn.lock
@@ -5154,10 +5154,10 @@ json-pointer@0.6.0, json-pointer@^0.6.0:
   dependencies:
     foreach "^2.0.4"
 
-json-schema-faker@0.5.0-rc21:
-  version "0.5.0-rc21"
-  resolved "https://registry.yarnpkg.com/json-schema-faker/-/json-schema-faker-0.5.0-rc21.tgz#c6d932dd05106a4110138550880ed2169f51dd48"
-  integrity sha512-D4531ssZlE9ynsUIftqad2P8oIrM+m0DXff7Gas4tU8l9jC+fJ1ceUL21xTfF+gjpOqNoNXpvxpnXcxfq9r+kw==
+json-schema-faker@0.5.0-rc22:
+  version "0.5.0-rc22"
+  resolved "https://registry.yarnpkg.com/json-schema-faker/-/json-schema-faker-0.5.0-rc22.tgz#2235e9dd3c6e5309a98b9ed9cfd087e913d5859a"
+  integrity sha512-I4uHXHapmR9qLJtzZSEHhhri1LMsaFsw3PycmFq0lBCR2Q1oIRm0OTPJbSbmIyPLJgN4+8+WRgR3AF0qmU1XDw==
   dependencies:
     json-schema-ref-parser "^6.1.0"
     jsonpath-plus "^1.0.0"
