review: rename Attribute to InlineAttributes in MarkupXML

makesoftwaresafe · Jul 22, 2022 · fe14235 · fe14235
1 parent 0639a9e
commit fe14235
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/bindings/xml/comment-xml-schema.rng b/bindings/xml/comment-xml-schema.rng
@@ -959,7 +959,7 @@
           <param name="pattern">.*\S.*</param>
         </data>
       </element>
-      <element name="Attribute">
+      <element name="InlineAttributes">
         <attribute name="attributes"/>
         <!-- Non-empty text content. -->
         <data type="string">

diff --git a/lib/IDE/CommentConversion.cpp b/lib/IDE/CommentConversion.cpp
@@ -73,15 +73,15 @@ struct CommentToXMLConverter {
   }
 
   void printInlineAttributes(const InlineAttributes *A) {
-    OS << "<Attribute attributes=\"";
+    OS << "<InlineAttributes attributes=\"";
     appendWithXMLEscaping(OS, A->getAttributes());
     OS << "\">";
 
     for (const auto *N : A->getChildren()) {
       printASTNode(N);
     }
 
-    OS << "</Attribute>";
+    OS << "</InlineAttributes>";
   }
 
   void printBlockQuote(const BlockQuote *BQ) {

diff --git a/test/Inputs/comment_to_something_conversion.swift b/test/Inputs/comment_to_something_conversion.swift
@@ -68,7 +68,7 @@ public enum A012_AttachToEntities {
     ///
     /// ^[Attribute text](string: "attributed")
     @objc public func f0() {}
-    // CHECK: {{.*}}DocCommentAsXML=[<Function file="{{.*}}" line="{{.*}}" column="{{.*}}"><Name>f0()</Name><USR>c:@M@comment_to_xml@objc(cs)Attributes(im)f0</USR><Declaration>@objc public func f0()</Declaration><CommentParts><Abstract><Para>Here is an attribute:</Para></Abstract><Discussion><Para><Attribute attributes="string: &quot;attributed&quot;">Attribute text</Attribute></Para></Discussion></CommentParts></Function>]
+    // CHECK: {{.*}}DocCommentAsXML=[<Function file="{{.*}}" line="{{.*}}" column="{{.*}}"><Name>f0()</Name><USR>c:@M@comment_to_xml@objc(cs)Attributes(im)f0</USR><Declaration>@objc public func f0()</Declaration><CommentParts><Abstract><Para>Here is an attribute:</Para></Abstract><Discussion><Para><InlineAttributes attributes="string: &quot;attributed&quot;">Attribute text</InlineAttributes></Para></Discussion></CommentParts></Function>]
 }
 
 @objc public class AutomaticLink {