web/core/components/issues/issue-layouts/filters/header/display-filters/sub-group-by.tsx (1)

Line range hint 44-44: Inconsistent translation pattern for subGroupBy titles.

The title prop is using the hardcoded subGroupBy.title instead of following the translation pattern used in other components (t(subGroupBy.titleTranslationKey)).

Apply this diff to maintain consistency:

-                title={subGroupBy.title}
+                title={t(subGroupBy.titleTranslationKey)}

web/core/components/project/dropdowns/filters/created-at.tsx (1)

Line range hint 47-47: Add translation for "Created date" title

The title in DateFilterModal is still hardcoded and needs to be translated.

-          title="Created date"
+          title={t("created_date")}

web/core/components/issues/issue-layouts/filters/header/display-filters/display-properties.tsx (1)

Line range hint 68-87: Fix fragment key and optimize onClick handler

There are two issues in this code segment:

1. The fragment wrapper in the map function is missing a key prop
2. The onClick handler creates a new function on every render

-          {filteredDisplayProperties.map((displayProperty) => (
-            <>
+          {filteredDisplayProperties.map((displayProperty) => (
+            <React.Fragment key={displayProperty.key}>
               <button
-                key={displayProperty.key}
                 type="button"
                 className={`rounded border px-2 py-0.5 text-xs transition-all ${
                   displayProperties?.[displayProperty.key]
                     ? "border-custom-primary-100 bg-custom-primary-100 text-white"
                     : "border-custom-border-200 hover:bg-custom-background-80"
                 }`}
-                onClick={() =>
-                  handleUpdate({
-                    [displayProperty.key]: !displayProperties?.[displayProperty.key],
-                  })
-                }
+                onClick={handleUpdate.bind(null, {
+                  [displayProperty.key]: !displayProperties?.[displayProperty.key],
+                })}
               >
                 {t(displayProperty.titleTranslationKey)}
               </button>
-            </>
+            </React.Fragment>
           ))}

web/core/components/issues/issue-layouts/filters/header/filters/assignee.tsx (1)

Line range hint 93-94: Fix inconsistent translation usage for view toggles.

The "View less"/"View all" strings are hardcoded while other components use translation keys (t("view_less")/t("view_all")).

Apply this diff to maintain consistency:

-                    {itemsToRender === sortedOptions.length ? "View less" : "View all"}
+                    {itemsToRender === sortedOptions.length ? t("view_less") : t("view_all")}

web/core/components/issues/issue-detail/issue-activity/root.tsx (1)

Line range hint 142-155: Improve error handling in uploadCommentAsset

The error handling in uploadCommentAsset is inconsistent with other operations. It logs to console and throws a different error format.

 uploadCommentAsset: async (file, commentId) => {
   try {
     if (!workspaceSlug || !projectId) throw new Error(t("missing_fields"));
     const res = await fileService.uploadProjectAsset(
       workspaceSlug,
       projectId,
       {
         entity_identifier: commentId ?? "",
         entity_type: EFileAssetType.COMMENT_DESCRIPTION,
       },
       file
     );
     return res;
   } catch (error) {
-    console.log("Error in uploading comment asset:", error);
-    throw new Error(t("asset_upload_failed_please_try_again_later"));
+    setToast({
+      title: t("error"),
+      type: TOAST_TYPE.ERROR,
+      message: t("asset_upload_failed_please_try_again_later"),
+    });
+    throw error;
   }
 },

web/core/components/issues/peek-overview/root.tsx (2)

117-119: Consider translating all error messages consistently.

While the error messages for issue deletion and restoration are properly translated, there are other error messages in the file that still use hardcoded strings. For consistency, consider translating these messages as well:

• Line 191: "Issue could not be added to the cycle. Please try again."
• Line 220: "Issue could not be added to the cycle. Please try again."
• Lines 245-247: Error messages in setPromiseToast
• Lines 285-287: Error messages in setPromiseToast

Also applies to: 161-162

---

150-151: Consider translating all success messages consistently.

While the success message for issue restoration is properly translated, there are other success messages in the file that still use hardcoded strings. For consistency, consider translating these messages as well:

• Lines 245-247: Success messages in setPromiseToast
• Lines 285-287: Success messages in setPromiseToast

web/core/components/issues/issue-layouts/quick-add/root.tsx (1)

171-171: Simplify boolean expression and use optional chaining.

The current boolean expression can be simplified for better readability.

-hasError={errors && errors?.name && errors?.name?.message ? true : false}
+hasError={Boolean(errors?.name?.message)}

🧰 Tools

🪛 Biome (1.9.4)

[error] 171-171: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

[error] 171-171: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

web/core/components/issues/issue-layouts/quick-add/button/kanban.tsx (1)

16-16: Consider using a single translation key for better language support.

Instead of concatenating translated strings, use a single translation key with interpolation to better support languages with different word orders.

-      <span className="text-sm font-medium">{`${t("new")} ${isEpic ? t("epic") : t("issue")}`}</span>
+      <span className="text-sm font-medium">
+        {t(isEpic ? "new_epic" : "new_issue")}
+      </span>

web/core/components/issues/issue-layouts/quick-add/button/gantt.tsx (1)

Line range hint 1-22: Consider consolidating duplicate button components.

All four quick-add button components (Kanban, List, Spreadsheet, and Gantt) share nearly identical implementation, differing only in minor styling. Consider creating a single base component that accepts a variant prop to handle the styling differences.

Example approach:

type ButtonVariant = 'kanban' | 'list' | 'spreadsheet' | 'gantt';

interface QuickAddIssueButtonProps extends TQuickAddIssueButton {
  variant: ButtonVariant;
}

const variantStyles: Record<ButtonVariant, string> = {
  kanban: "py-1.5",
  list: "py-3",
  spreadsheet: "px-2 pt-3",
  gantt: "py-2"
};

export const QuickAddIssueButton: FC<QuickAddIssueButtonProps> = observer((props) => {
  const { onClick, isEpic = false, variant } = props;
  const { t } = useTranslation();

  return (
    <button
      type="button"
      className={cn(
        "flex items-center gap-2 text-custom-text-350 hover:text-custom-text-300",
        variantStyles[variant]
      )}
      onClick={onClick}
    >
      <PlusIcon className="h-3.5 w-3.5 stroke-2" />
      <span className="text-sm font-medium">
        {t(isEpic ? "new_epic" : "new_issue")}
      </span>
    </button>
  );
});

web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/issues/(list)/page.tsx (1)

24-24: Consider DRY principle for title construction

The same title construction ${project?.name} - ${t("issues")} is duplicated in both the pageTitle variable and the title element. Consider extracting this into a constant to follow DRY principles.

  const { t } = useTranslation();
+ const constructedTitle = project?.name ? `${project.name} - ${t("issues")}` : undefined;
- const pageTitle = project?.name ? `${project?.name} - ${t("issues")}` : undefined;

  return (
    <>
-     <PageHead title={pageTitle} />
+     <PageHead title={constructedTitle} />
      <Head>
-       <title>
-         {project?.name} - {t("issues")}
-       </title>
+       <title>{constructedTitle}</title>
      </Head>

Also applies to: 30-32

web/core/components/issues/issue-layouts/save-filter-view.tsx (1)

36-38: Consider adding aria-label for better accessibility

The translation implementation looks good. Consider adding an aria-label to improve accessibility.

-     <Button size="sm" onClick={() => setViewModal(true)}>
+     <Button 
+       size="sm" 
+       onClick={() => setViewModal(true)} 
+       aria-label={t("save_view")}
+     >
        {t("save_view")}
      </Button>

web/core/components/issues/issue-layouts/filters/header/display-filters/extra-options.tsx (1)

3-3: LGTM with a suggestion for type safety.

The translation implementation is correct, but we could enhance type safety.

Consider adding type checking for translation keys:

// Add to your types file
type TranslationKey = keyof typeof import('@plane/i18n').translations.en;

// Update the option type
interface IssueExtraOption {
  key: TIssueExtraOptions;
  titleTranslationKey: TranslationKey;
}

Also applies to: 23-23, 37-37

web/core/components/issues/issue-layouts/quick-add/form/calendar.tsx (1)

3-3: LGTM with a DRY principle suggestion.

The translation implementation is correct but duplicates logic from spreadsheet.tsx.

Consider extracting common translation logic into a shared hook:

// hooks/useIssueFormTranslations.ts
export const useIssueFormTranslations = (isEpic: boolean) => {
  const { t } = useTranslation();
  return {
    placeholder: isEpic ? t("epic_title") : t("issue_title"),
    requiredMessage: `${isEpic ? t("epic") : t("issue")} ${t("title_is_required")}.`,
  };
};

This would reduce duplication across different form components (calendar, spreadsheet, etc.).

Also applies to: 8-8, 24-24, 26-26

web/core/components/issues/issue-layouts/quick-add/form/list.tsx (1)

29-29: Consider simplifying the template literal.

The translation string looks good, but the template literal could be simplified by moving the entire string into a single translation key.

Instead of:

`${t("press_enter_to_add_another")} ${isEpic ? t("epic") : t("issue")}`

Consider adding a translation key like:

t(isEpic ? "press_enter_to_add_another_epic" : "press_enter_to_add_another_issue")

This would make translations more natural in languages with different word orders.

web/core/constants/filters.ts (1)

4-4: Consider using more semantic translation keys.

The translation keys are directly derived from the English text (e.g., "1_week_from_now"). Consider using more semantic keys that describe the meaning rather than the text.

Example:

-    nameTranslationKey: "1_week_from_now",
+    nameTranslationKey: "date_filter.future.one_week",

This makes the translation system more maintainable and less tied to specific text.

Also applies to: 9-9, 14-14, 19-19, 27-27, 32-32, 37-37

web/core/components/issues/issue-layouts/filters/header/display-filters/issue-grouping.tsx (2)

30-30: Consider using a single translation key for the title.

The current implementation concatenates multiple translated strings, which might not work well for all languages due to different word orders.

Instead of:

`${isEpic ? t("epic") : t("issue")} ${t("grouping")}`

Consider:

t(isEpic ? "epic_grouping_title" : "issue_grouping_title")

---

41-41: Simplify the translation string composition.

Similar to the title, the option text combines multiple translations which could lead to grammatical issues in some languages.

Instead of:

`${t(issueType?.titleTranslationKey)} ${isEpic ? t("epics") : t("issues")}`

Consider:

t(isEpic ? `epic_group_by_${issueType?.titleTranslationKey}` : `issue_group_by_${issueType?.titleTranslationKey}`)

web/core/components/issues/issue-layouts/quick-add/form/gantt.tsx (1)

24-24: Consider simplifying the template string.

The translation can be simplified by using a single translation key for the full message instead of composing it from multiple parts.

Instead of:

`${isEpic ? t("epic") : t("issue")} ${t("title_is_required")}.`

Consider adding translation keys like:

t(isEpic ? "epic_title_required" : "issue_title_required")

This approach is more maintainable as it allows translators to handle the full sentence structure according to their language's grammar rules.

web/core/components/core/filters/date-filter-select.tsx (1)

50-51: Reduce code duplication in translation key access.

The pattern for accessing and translating the date range item is duplicated. Consider extracting it to a helper function.

const getTranslatedOption = (value: string) => {
  const option = dueDateRange.find((item) => item.value === value);
  return option ? `${title} ${t(option.nameTranslationKey)}` : t("select_date");
};

Then use it like:

<span>{getTranslatedOption(value)}</span>

Also applies to: 59-61

web/core/components/issues/create-issue-toast-action-items.tsx (1)

54-54: Optimize complex string interpolation.

The current implementation concatenates multiple translated strings. Consider using a single translation key with interpolation for better maintainability and context for translators.

Instead of:

`${t("view")} ${isEpic ? t("epic") : t("issue")}`

Consider:

t("view_item", { item: isEpic ? t("epic") : t("issue") })

Add to translation file:

{
  "view_item": "View {{item}}"
}

web/core/components/issues/issue-layouts/filters/header/filters/state-group.tsx (1)

20-22: Remove unnecessary i18n comment.

The comment // i18n is redundant as the hook usage is self-documenting.

- // i18n
  const { t } = useTranslation();

web/core/components/issues/issue-layouts/filters/header/filters/start-date.tsx (1)

19-20: Remove unnecessary i18n comment.

The comment // i18n is redundant as the hook usage is self-documenting.

- // i18n
  const { t } = useTranslation();

web/core/components/issues/issue-layouts/filters/header/filters/target-date.tsx (2)

52-52: Consider using translation interpolation instead of string concatenation

Replace string concatenation with translation interpolation for better i18n practices.

-        title={`${t("target_date")}${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}
+        title={t("target_date_with_count", { count: appliedFiltersCount })}

---

Line range hint 61-67: Remove unnecessary fragment wrapper in map function

The fragment wrapper is not needed since each mapped item is a single element.

-              {filteredOptions.map((option) => (
-                <FilterOption
-                  key={option.value}
-                  isChecked={appliedFilters?.includes(option.value) ? true : false}
-                  onClick={() => handleUpdate(option.value)}
-                  title={t(option.nameTranslationKey)}
-                  multiple
-                />
-              ))}
+              {filteredOptions.map((option) => 
+                <FilterOption
+                  key={option.value}
+                  isChecked={appliedFilters?.includes(option.value) ? true : false}
+                  onClick={() => handleUpdate(option.value)}
+                  title={t(option.nameTranslationKey)}
+                  multiple
+                />
+              )}

🧰 Tools

🪛 Biome (1.9.4)

[error] 63-63: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

web/core/components/issues/issue-layouts/filters/header/filters/labels.tsx (1)

58-58: Fix extra space in title string interpolation.

The template literal has an extra space after ${t("label")} which could cause inconsistent spacing in different translations.

-        title={`${t("label")}${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}
+        title={`${t("label")}${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}

web/core/components/issues/issue-layouts/filters/header/filters/module.tsx (2)

57-57: Fix inconsistent spacing in title string interpolation.

The template literal has extra spaces that could cause inconsistent spacing in different translations.

-        title={`${t("module")} ${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}
+        title={`${t("module")}${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}

---

Line range hint 68-74: Fix incorrect variable naming in map function.

The variable name 'cycle' is used in the map function but this component is for modules, which could cause confusion.

-                {sortedOptions.slice(0, itemsToRender).map((cycle) => (
+                {sortedOptions.slice(0, itemsToRender).map((module) => (
                   <FilterOption
-                    key={cycle.id}
-                    isChecked={appliedFilters?.includes(cycle.id) ? true : false}
-                    onClick={() => handleUpdate(cycle.id)}
+                    key={module.id}
+                    isChecked={appliedFilters?.includes(module.id) ? true : false}
+                    onClick={() => handleUpdate(module.id)}
                     icon={<DiceIcon className="h-3 w-3 flex-shrink-0" />}
-                    title={cycle.name}
+                    title={module.name}
                   />
                 ))}

web/core/components/issues/issue-layouts/filters/header/filters/project.tsx (1)

55-55: Fix inconsistent spacing in title string interpolation.

The template literal has extra spaces that could cause inconsistent spacing in different translations.

-        title={`${t("project")}${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}
+        title={`${t("project")}${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}

web/core/components/issues/issue-layouts/filters/header/filters/created-by.tsx (3)

59-59: Fix inconsistent spacing in title string interpolation.

The template literal has extra spaces that could cause inconsistent spacing in different translations.

-        title={`${t("created_by")}${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}
+        title={`${t("created_by")}${appliedFiltersCount > 0 ? ` (${appliedFiltersCount})` : ""}`}

---

Line range hint 73-79: Simplify boolean expression in isChecked prop.

The ternary operator returning a boolean can be simplified.

                    <FilterOption
                      key={`created-by-${member.id}`}
-                      isChecked={appliedFilters?.includes(member.id) ? true : false}
+                      isChecked={Boolean(appliedFilters?.includes(member.id))}
                      onClick={() => handleUpdate(member.id)}
                      icon={<Avatar name={member.display_name} src={getFileURL(member.avatar_url)} size="md" />}
                      title={currentUser?.id === member.id ? t("you") : member?.display_name}
                    />

🧰 Tools

🪛 Biome (1.9.4)

[error] 75-75: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

6-6: Overall i18n implementation looks good but needs standardization.

The internationalization implementation is consistent across all filter components. However, consider creating a utility function for formatting filter titles to ensure consistent spacing and reduce duplication. This would help maintain consistency as more filters are added.

Example utility function:

const formatFilterTitle = (key: string, count: number) => 
  `${t(key)}${count > 0 ? ` (${count})` : ""}`;

Then use it like:

title={formatFilterTitle("label", appliedFiltersCount)}

Also applies to: 6-6, 6-6, 7-7

web/core/components/issues/issue-layouts/filters/header/filters/cycle.tsx (1)

90-90: Consider handling plural forms for view_all/view_less translations.

The current implementation uses simple translation keys. Consider using plural forms if the translations might vary based on the number of items in different languages.

Also applies to: 95-95

web/core/components/dropdowns/module/module-options.tsx (1)

132-132: Consider improving type safety for displayValue prop.

The displayValue prop uses any type which could lead to type-safety issues.

-displayValue={(assigned: any) => assigned?.name}
+displayValue={(assigned: { name: string }) => assigned?.name}

web/core/components/issues/filters.tsx (1)

144-147: Consider adding ARIA label for better accessibility.

The analytics button could benefit from an ARIA label to improve screen reader support.

-<Button className="hidden md:block" onClick={() => setAnalyticsModal(true)} variant="neutral-primary" size="sm">
+<Button 
+  className="hidden md:block" 
+  onClick={() => setAnalyticsModal(true)} 
+  variant="neutral-primary" 
+  size="sm"
+  aria-label={t("open_project_analytics")}
+>
   {t("analytics")}
 </Button>

web/core/components/dropdowns/cycle/cycle-options.tsx (1)

169-169: Consider enhancing loading state feedback

The loading state could be improved by adding a loading spinner or skeleton component alongside the loading text for better user experience.

web/core/components/core/filters/date-filter-modal.tsx (1)

141-145: Consider date localization

While the text is properly translated, consider using a date formatting library that supports localization (e.g., Intl.DateTimeFormat) for the rendered dates to ensure they follow the user's locale conventions.

-      <span>{renderFormattedDate(watch("date1"))}</span>
+      <span>{new Intl.DateTimeFormat(i18n.language).format(watch("date1"))}</span>
-      {!isInvalid && <span>{renderFormattedDate(watch("date2"))}</span>}
+      {!isInvalid && <span>{new Intl.DateTimeFormat(i18n.language).format(watch("date2"))}</span>}

web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/issues/(list)/mobile-header.tsx (1)

109-113: Enhance accessibility for layout selection

Add ARIA labels to improve screen reader support for the layout selection menu.

 <div className="flex flex-start text-sm text-custom-text-200">
   {t("layout")}
-  <ChevronDown className="ml-2  h-4 w-4 text-custom-text-200 my-auto" strokeWidth={2} />
+  <ChevronDown 
+    className="ml-2 h-4 w-4 text-custom-text-200 my-auto" 
+    strokeWidth={2}
+    aria-hidden="true"
+  />
 </div>

web/core/constants/issue.ts (2)

51-63: Consider using dot notation for hierarchical translation keys.

While the current implementation works, consider using dot notation (e.g., state.groups instead of state_groups) for better organization and maintainability of translation keys.

---

144-183: Consider consolidating layout-related translation keys.

The layout mapping includes both titleTranslationKey and labelTranslationKey. Consider:

1. Using a single translation key if the title and label are always the same
2. Using a consistent prefix for layout-related keys

packages/i18n/src/locales/en/translations.json (1)

319-396: Ensure consistent capitalization in translations.

Some translations have inconsistent capitalization:

• "Sub issue count" vs. "Sub-group by"
• "Last created" vs. "Last Updated"

Consider standardizing the capitalization rules.

packages/i18n/src/locales/fr/translations.json (1)

319-319: Fix capitalization in French translation.

The translation for "inbox" should be capitalized as it's used as a UI element name.

-  "inbox": "Boîte de réception",
+  "inbox": "Boîte de Réception",

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

web/core/components/core/filters/date-filter-select.tsx (1)

23-39: Consider using more specific translation keys.

The translation keys currently mirror the English names, which might lead to confusion and maintenance issues. Consider using more specific keys that follow a hierarchical structure.

 const dueDateRange: DueDate[] = [
   {
-    nameTranslationKey: "before",
+    nameTranslationKey: "date_filter.before",
     name: "before",
     value: "before",
     icon: <CalendarBeforeIcon className="h-4 w-4" />,
   },
   {
-    nameTranslationKey: "after",
+    nameTranslationKey: "date_filter.after",
     name: "after",
     value: "after",
     icon: <CalendarAfterIcon className="h-4 w-4" />,
   },
   {
-    nameTranslationKey: "range",
+    nameTranslationKey: "date_filter.range",
     name: "range",
     value: "range",
     icon: <CalendarDays className="h-4 w-4" />,
   },
 ];

packages/i18n/src/locales/fr/translations.json (1)

323-329: Maintain consistency in layout terminology.

The translations for layout types are good, but consider standardizing the term "disposition" usage:

• "Disposition de liste"
• "Disposition de tableau" (used twice for both "board" and "table")

Consider using "tableau de bord" for "board_layout" to differentiate it from "table_layout":

-  "board_layout": "Disposition de tableau",
+  "board_layout": "Disposition de tableau de bord",

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro