Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-3168] fix: draft issue fetch #6416

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[WEB-3168] fix: draft issue fetch #6416

merged 1 commit into from
Jan 17, 2025

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Jan 17, 2025 •
edited
Loading

Description

This PR addresses workspace draft issue fetch bug.

Type of Change

  • Bug fix

References

[WEB-3168]

Summary by CodeRabbit

  • Bug Fixes

    • Improved issue fetching logic to prevent duplicate issue IDs in workspace draft issues
    • Optimized data retrieval for workspace draft issues by adjusting data fetching conditions

  • Performance

    • Modified SWR hook configuration to reduce unnecessary data revalidation
    • Enhanced data management to ensure more efficient issue tracking

@anmolsinghbhatia anmolsinghbhatia added this to the v0.24.2 milestone Jan 17, 2025
@anmolsinghbhatia anmolsinghbhatia self-assigned this Jan 17, 2025
@makeplane MakePlane
Copy link

makeplane bot commented Jan 17, 2025

Pull Request Linked with Plane Issues

Comment Automatically Generated by Plane

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2025 •
edited
Loading

Walkthrough

The pull request introduces modifications to the issue management system, specifically focusing on the workspace draft issues. Changes are made in two key files: root.tsx and issue.store.ts. The modifications alter the data fetching logic for workspace draft issues, adjusting the conditions for fetching and ensuring unique issue ID tracking. The changes aim to improve data integrity and control flow in issue retrieval and storage.

Changes

File Change Summary
web/core/components/issues/workspace-draft/root.tsx - Modified useSWR hook conditions for fetching issues
- Removed dependency on issueIds array length
- Added revalidateOnFocus and revalidateIfStale options set to false
web/core/store/issue/workspace-draft/issue.store.ts - Updated fetchIssues method in WorkspaceDraftIssues class
- Introduced existingIssueIds and newIssueIds variables
- Ensured only unique issue IDs are added to issueMapIds

Sequence Diagram

sequenceDiagram
    participant Component as WorkspaceDraftIssuesRoot
    participant Store as WorkspaceDraftIssues
    participant API as Backend API

    Component->>Store: fetchIssues(workspaceSlug)
    Store->>API: Request issues
    API-->>Store: Return issue data
    Store->>Store: Filter unique issue IDs
    Store->>Store: Update issueMapIds
    Store-->>Component: Return updated issues
Loading

Possibly related PRs

Suggested reviewers

  • sriramveeraghanta
  • SatishGandham
  • rahulramesha

Poem

🐰 Hopping through code with glee,
Issues draft, now clean and free!
No duplicates shall slip right through,
Our data dance, precise and true!
Fetch and filter, rabbit's delight! 🚀

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95f43a7 and 18f363e.

📒 Files selected for processing (2)
  • web/core/components/issues/workspace-draft/root.tsx (1 hunks)
  • web/core/store/issue/workspace-draft/issue.store.ts (1 hunks)
🔇 Additional comments (2)
web/core/components/issues/workspace-draft/root.tsx (1)

37-39: LGTM! Improved data fetching logic.

The changes improve the fetching behavior by:

  1. Removing the circular dependency on issueIds.length
  2. Adding cache control to prevent unnecessary revalidation
web/core/store/issue/workspace-draft/issue.store.ts (1)

236-241: LGTM! Fixed duplicate issue handling.

The changes prevent duplicate issues by:

  1. Tracking existing issue IDs
  2. Only adding new, unique issues to the list
  3. Maintaining correct order (new issues first)

This fix works well with the changes in root.tsx to ensure data consistency.

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review January 17, 2025 07:07
@pushya22 pushya22 merged commit 20893c6 into preview Jan 17, 2025
20 of 22 checks passed
@pushya22 pushya22 deleted the fix-draft-issue-fetch branch January 17, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pushya22 pushya22 pushya22 approved these changes

@rahulramesha rahulramesha rahulramesha approved these changes

@sriramveeraghanta sriramveeraghanta Awaiting requested review from sriramveeraghanta

@gurusainath gurusainath Awaiting requested review from gurusainath

Assignees

@anmolsinghbhatia anmolsinghbhatia

Labels
🐛bug Something isn't working 🧹chore 🌐frontend
Projects
None yet
Milestone
v0.24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@anmolsinghbhatia @rahulramesha @pushya22