Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correcting french translations. #6383

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: correcting french translations. #6383

merged 1 commit into from
Jan 15, 2025

Conversation

tamdaz
Copy link
Contributor

@tamdaz tamdaz commented Jan 11, 2025 •
edited
Loading

Description

Correcting some french sentences for more consistency.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

  • Localization
    • Updated French translations for various UI elements and messages
    • Improved grammatical accuracy and clarity of translation phrases
    • Refined terminology for workspaces, permissions, and user interface labels

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 11, 2025 •
edited
Loading

Walkthrough

This pull request focuses on refining the French translations in the translations.json file. The changes primarily involve grammatical improvements, terminology updates, and clarification of existing translation strings. The modifications aim to enhance the linguistic accuracy and readability of the French localization, addressing nuanced language details such as article usage, phrasing, and formatting consistency.

Changes

File Change Summary
packages/i18n/src/locales/fr/translations.json - Updated grammatical structures
- Refined terminology (e.g., "Nom d'affichage" → "Pseudonyme")
- Improved translation clarity
- Corrected formatting and capitalization

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

  • rahulramesha
  • prateekshourya29

Possibly related PRs

Poem

🐰 A Rabbit's Localization Delight

In French, each word must shine just right,
With articles and spaces tight,
Translations dance, both clear and bright,
From "Workspace" to "Espace de travail" so light!
Linguistic magic takes its flight! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ade4d29 and b5867d8.

📒 Files selected for processing (1)
  • packages/i18n/src/locales/fr/translations.json (8 hunks)
🔇 Additional comments (9)
packages/i18n/src/locales/fr/translations.json (9)

22-22: LGTM! Improved grammar with article addition

The addition of the article "un" makes the translation more grammatically correct in French.

27-27: LGTM! Better terminology choice

"Pseudonyme" is a more appropriate and commonly used term in French for display names in user interfaces.

46-47: LGTM! Consistent localization of workspace terms

The translations now properly localize "workspace" to "espace de travail" throughout the interface, maintaining consistency and improving user understanding.

53-53: LGTM! Correct preposition usage

The use of "d'" with "accéder" is the correct grammatical construction in French.

65-65: LGTM! More natural phrasing

The use of "faire au moins" is more natural in French when discussing measurements or requirements.

195-196: LGTM! Consistent and correct French syntax

The translation now correctly uses French word order for "ID du projet" across all related messages.

Also applies to: 201-201

203-203: LGTM! Proper localization of business term

"Responsable" is the appropriate French translation for "lead" in a professional context.

248-248: LGTM! Correct French typography

Added the required space before the question mark, following French typography rules.

319-319: LGTM! Consistent capitalization

Capitalization now matches the style used throughout the interface.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta
Copy link
Contributor

@tamdaz Changes looks good to us, Please sign the Contributor License Agreement for it to get merged. You can find it under a comment in this PR. Thank you.

@tamdaz
Copy link
Contributor Author

tamdaz commented Jan 15, 2025

The CLA has been signed.

@sriramveeraghanta sriramveeraghanta merged commit 9d71568 into makeplane:preview Jan 15, 2025
2 of 3 checks passed
This was referenced Jan 17, 2025
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamdaz @CLAassistant @sriramveeraghanta