Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2338] chore: handle untitled page breadcrumbs #5445

Merged
merged 2 commits into from
Aug 28, 2024
Merged

[WEB-2338] chore: handle untitled page breadcrumbs #5445

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e9f7f
chore: handle untitle page titles
aaryan610 Aug 28, 2024
baf5a06
chore: store page title in a const
aaryan610 Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: store page title in a const
  • Loading branch information
@aaryan610
aaryan610 committed Aug 28, 2024
commit baf5a068f1d2a1f9bac3d1f532f39b4ea9fb19d5
5 changes: 3 additions & 2 deletions web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export const PageDetailsHeader = observer(() => {
}
};

const pageTitle = getPageName(name);
const isVersionHistoryOverlayActive = !!searchParams.get("version");

return (
Expand Down Expand Up @@ -147,9 +148,9 @@ export const PageDetailsHeader = observer(() => {
}
/>
</div>
<Tooltip tooltipContent={getPageName(name)} position="bottom" isMobile={isMobile}>
<Tooltip tooltipContent={pageTitle} position="bottom" isMobile={isMobile}>
<div className="relative line-clamp-1 block max-w-[150px] overflow-hidden truncate">
{getPageName(name)}
{pageTitle}
</div>
</Tooltip>
</div>
Expand Down
Loading