Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address form fields will accept any value #89

Open
1 task done
MaxwellGarceau opened this issue Dec 24, 2024 · 0 comments
Open
1 task done

Address form fields will accept any value #89

MaxwellGarceau opened this issue Dec 24, 2024 · 0 comments
Labels
type:bug Something isn't working.

Comments

@MaxwellGarceau
Copy link
Collaborator

Describe the bug

Bug: Address validation

Currently, any value is acceptable for the address fields. The only validation check is that if one address field is filled out then they all must be filled out.

The current validation set up may be a bug because judging by the code only address line 1 and city should be required.

Input to Mailchimp web form

invalid-form-data-form-submission.pdf

Output in Mailchimp account

invalid-form-data-mailchimp-account

Enhancement: Additional Validation

Other possible validation improvements. These areas may be better to leave without validation in order to accommodate the range of possible values, but that decision should be documented.

  • International phone number validation
  • First Name - Name validation is tricky. We can probably skip this field.
  • Last Name - Name validation is tricky. We can probably skip this field.
  • Company (it's probably okay to not have validation here)
  • Birthday (validation exists)
  • Country (is dropdown list, we're okay here)

Documentation

The following would be great to have recorded

  • What fields are being validated (and why some fields aren't)
  • Does the Mailchimp API perform any validation? Does this validation make it back to the plugin?
  • Does explicit validation only occur on the backend?
  • What is the sanitization strategy?

Steps to Reproduce

  1. Fill out the Mailchimp form on the FE with a valid and invalid data for every address field
  2. Click submit
  3. You may need to check the email being subscribed and pass the captcha check
  4. Log into the connected Mailchimp account and examine the contact
  5. The contact will have invalid address data

Screenshots, screen recording, code snippet

Input to Mailchimp web form

invalid-form-data-form-submission.pdf

Output in Mailchimp account

invalid-form-data-mailchimp-account

Environment information

  • Macbook Air
  • OS: 14.6
  • Chrome 131.0.6778.205

WordPress information

`

wp-core

version: 6.7.1
site_language: en_US
user_language: en_US
timezone: +00:00
permalink: undefined
https_status: false
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: open
environment_type: local
user_count: 1
dotorg_communication: true

wp-paths-sizes

wordpress_path: /var/www/html
wordpress_size: loading...
uploads_path: /var/www/html/wp-content/uploads
uploads_size: loading...
themes_path: /var/www/html/wp-content/themes
themes_size: loading...
plugins_path: /var/www/html/wp-content/plugins
plugins_size: loading...
fonts_path: /var/www/html/wp-content/uploads/fonts
fonts_size: loading...
database_size: loading...
total_size: loading...

wp-active-theme

name: Twenty Twenty-Five (twentytwentyfive)
version: 1.0
author: the WordPress team
author_website: https://wordpress.org
parent_theme: none
theme_features: core-block-patterns, post-thumbnails, responsive-embeds, editor-styles, html5, automatic-feed-links, widgets-block-editor, block-templates, post-formats, editor-style
theme_path: /var/www/html/wp-content/themes/twentytwentyfive
auto_update: Disabled

wp-themes-inactive (14)

Twenty Eleven: version: 4.8, author: the WordPress team, Auto-updates disabled
Twenty Fifteen: version: 3.9, author: the WordPress team, Auto-updates disabled
Twenty Fourteen: version: 4.1, author: the WordPress team, Auto-updates disabled
Twenty Nineteen: version: 3.0, author: the WordPress team, Auto-updates disabled
Twenty Seventeen: version: 3.8, author: the WordPress team, Auto-updates disabled
Twenty Sixteen: version: 3.4, author: the WordPress team, Auto-updates disabled
Twenty Ten: version: 4.3, author: the WordPress team, Auto-updates disabled
Twenty Thirteen: version: 4.3, author: the WordPress team, Auto-updates disabled
Twenty Twelve: version: 4.4, author: the WordPress team, Auto-updates disabled
Twenty Twenty: version: 2.8, author: the WordPress team, Auto-updates disabled
Twenty Twenty-Four: version: 1.3, author: the WordPress team, Auto-updates disabled
Twenty Twenty-One: version: 2.4, author: the WordPress team, Auto-updates disabled
Twenty Twenty-Three: version: 1.6, author: the WordPress team, Auto-updates disabled
Twenty Twenty-Two: version: 1.9, author: the WordPress team, Auto-updates disabled

wp-plugins-active (1)

Mailchimp: version: 1.6.2, author: Mailchimp, Auto-updates disabled

wp-plugins-inactive (1)

Hello Dolly: version: 1.7.2, author: Matt Mullenweg, Auto-updates disabled

wp-media

image_editor: WP_Image_Editor_Imagick
imagick_module_version: 1691
imagemagick_version: ImageMagick 6.9.11-60 Q16 aarch64 2021-01-25 https://imagemagick.org
imagick_version: 3.7.0
file_uploads: 1
post_max_size: 1G
upload_max_filesize: 1G
max_effective_size: 1 GB
max_file_uploads: 20
imagick_limits:
imagick::RESOURCETYPE_AREA: 122 MB
imagick::RESOURCETYPE_DISK: 1073741824
imagick::RESOURCETYPE_FILE: 786432
imagick::RESOURCETYPE_MAP: 512 MB
imagick::RESOURCETYPE_MEMORY: 256 MB
imagick::RESOURCETYPE_THREAD: 1
imagick::RESOURCETYPE_TIME: 9.2233720368548E+18
imagemagick_file_formats: 3FR, 3G2, 3GP, AAI, AI, APNG, ART, ARW, AVI, AVIF, AVS, BGR, BGRA, BGRO, BIE, BMP, BMP2, BMP3, BRF, CAL, CALS, CANVAS, CAPTION, CIN, CIP, CLIP, CMYK, CMYKA, CR2, CR3, CRW, CUR, CUT, DATA, DCM, DCR, DCX, DDS, DFONT, DNG, DPX, DXT1, DXT5, EPDF, EPI, EPS, EPS2, EPS3, EPSF, EPSI, EPT, EPT2, EPT3, ERF, FAX, FILE, FITS, FRACTAL, FTP, FTS, G3, G4, GIF, GIF87, GRADIENT, GRAY, GRAYA, GROUP4, H, HALD, HDR, HEIC, HISTOGRAM, HRZ, HTM, HTML, HTTP, HTTPS, ICB, ICO, ICON, IIQ, INFO, INLINE, IPL, ISOBRL, ISOBRL6, J2C, J2K, JBG, JBIG, JNG, JNX, JP2, JPC, JPE, JPEG, JPG, JPM, JPS, JPT, JSON, K25, KDC, LABEL, M2V, M4V, MAC, MAGICK, MAP, MASK, MAT, MATTE, MEF, MIFF, MKV, MNG, MONO, MOV, MP4, MPC, MPG, MRW, MSL, MTV, MVG, NEF, NRW, NULL, ORF, OTB, OTF, PAL, PALM, PAM, PATTERN, PBM, PCD, PCDS, PCL, PCT, PCX, PDB, PDF, PDFA, PEF, PES, PFA, PFB, PFM, PGM, PGX, PICON, PICT, PIX, PJPEG, PLASMA, PNG, PNG00, PNG24, PNG32, PNG48, PNG64, PNG8, PNM, POCKETMOD, PPM, PREVIEW, PS, PS2, PS3, PSB, PSD, PTIF, PWP, RADIAL-GRADIENT, RAF, RAS, RAW, RGB, RGBA, RGBO, RGF, RLA, RLE, RMF, RW2, SCR, SCT, SFW, SGI, SHTML, SIX, SIXEL, SPARSE-COLOR, SR2, SRF, STEGANO, SUN, TEXT, TGA, THUMBNAIL, TIFF, TIFF64, TILE, TIM, TTC, TTF, TXT, UBRL, UBRL6, UIL, UYVY, VDA, VICAR, VID, VIDEO, VIFF, VIPS, VST, WBMP, WEBM, WEBP, WMV, WPG, X, X3F, XBM, XC, XCF, XPM, XPS, XV, XWD, YCbCr, YCbCrA, YUV
gd_version: bundled (2.1.0 compatible)
gd_formats: GIF, JPEG, PNG, WebP, BMP, AVIF
ghostscript_version: 10.00.0

wp-server

server_architecture: Linux 6.10.14-linuxkit aarch64
httpd_software: Apache/2.4.62 (Debian)
php_version: 8.2.27 64bit
php_sapi: apache2handler
max_input_variables: 1000
time_limit: 30
memory_limit: 128M
admin_memory_limit: 256M
max_input_time: -1
upload_max_filesize: 1G
php_post_max_size: 1G
curl_version: 7.88.1 OpenSSL/3.0.15
suhosin: false
imagick_availability: true
pretty_permalinks: true
current: 2024-12-24T17:53:16+00:00
utc-time: Tuesday, 24-Dec-24 17:53:16 UTC
server-time: 2024-12-24T17:53:16+00:00

wp-database

extension: mysqli
server_version: 11.4.4-MariaDB-ubu2404
client_version: mysqlnd 8.2.27
max_allowed_packet: 16777216
max_connections: 151

wp-constants

WP_HOME: http://localhost:8888
WP_SITEURL: http://localhost:8888
WP_CONTENT_DIR: /var/www/html/wp-content
WP_PLUGIN_DIR: /var/www/html/wp-content/plugins
WP_MEMORY_LIMIT: 40M
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: true
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: true
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_ENVIRONMENT_TYPE: local
WP_DEVELOPMENT_MODE: undefined
DB_CHARSET: utf8
DB_COLLATE: undefined

wp-filesystem

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable
fonts: not writable

`

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MaxwellGarceau MaxwellGarceau added the type:bug Something isn't working. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant