Merge pull request #1493 from mailchimp/Issue1475-2.4

fix problem with developer mode #1475 for magento 2.4
mailchimp · Aug 9, 2022 · faf1f47 · faf1f47
2 parents 299d59e + b236d68
commit faf1f47
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Helper/Data.php b/Helper/Data.php
@@ -48,8 +48,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
     const XML_MAGENTO_MAIL           = 'mailchimp/general/magentoemail';
     const XML_SEND_PROMO             = 'mailchimp/ecommerce/send_promo';
     const XML_INCLUDING_TAXES        = 'mailchimp/ecommerce/including_taxes';
-    const XML_POPUP_FORM             = 'mailchimp/general/popup-form';
-    const XML_POPUP_URL              = 'mailchimp/general/popup-url';
+    const XML_POPUP_FORM             = 'mailchimp/general/popup_form';
+    const XML_POPUP_URL              = 'mailchimp/general/popup_url';
 
     const ORDER_STATE_OK             = 'complete';
 

diff --git a/etc/adminhtml/system.xml b/etc/adminhtml/system.xml
@@ -68,20 +68,20 @@
                         <field id="*/*/active">1</field>
                     </depends>
                 </field>
-                <field id="popup-form" translate="label" type="select" sortOrder="42" showInStore="1" showInWebsite="1" showInDefault="1">
+                <field id="popup_form" translate="label" type="select" sortOrder="42" showInStore="1" showInWebsite="1" showInDefault="1">
                     <label>Change the footer link</label>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                     <comment>Enabling this, the "Subscribe" button at the bottom open a popup with the Mailchimp subscription form</comment>
                     <depends>
                         <field id="*/*/active">1</field>
                     </depends>
                 </field>
-                <field id="popup-url" translate="label" type="text" sortOrder="43" showInDefault="1" showInWebsite="1" showInStore="1">
+                <field id="popup_url" translate="label" type="text" sortOrder="43" showInDefault="1" showInWebsite="1" showInStore="1">
                     <label>Popup Url</label>
                     <comment>Paste the form URL from your MailChimp audience</comment>
                     <depends>
                         <field id="*/*/active">1</field>
-                        <field id="*/*/popup-form">1</field>
+                        <field id="*/*/popup_form">1</field>
                     </depends>
                 </field>