Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for python 3.13 #376

Merged
merged 3 commits into from
Dec 23, 2024
Merged

add support for python 3.13 #376

merged 3 commits into from
Dec 23, 2024

Conversation

branchvincent
Copy link
Contributor

This is mainly just declaring official support for 3.13

@mahmoud
Copy link
Owner

mahmoud commented Dec 6, 2024

Hey Branch! This is great. Looks like there's a blocker on Windows CI. Something about a getuser failure, caused by ModuleNotFoundError: No module named 'pwd'. Might be due to something related to pytest's tmp_path fixture?

If it's tmp_path, then it might be fixed by a pytest version bump. Feel free to upgrade dependencies; we can drop 3.7 if need be. If it's worse than that, or if it's easier, we can probably make our own, simpler temporary path fixture that won't hit the Windows getuser issue. Wdyt?

@branchvincent
Copy link
Contributor Author

If it's tmp_path, then it might be fixed by a pytest version bump

Yup, you were spot on! Looks like we just need pytest-dev/pytest@14d3707. I updated to a more recent pytest version for 3.8+, so we can keep 3.7 support around 😄

@mahmoud mahmoud merged commit ad14437 into mahmoud:master Dec 23, 2024
10 checks passed
@mahmoud
Copy link
Owner

mahmoud commented Dec 23, 2024

Excellent! Merged with gusto. Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants