fix(amf): Correct MSIN decoding for SUCI Profile B #15499
+62
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
The fix works for MSIN decoding with ProfileA as well. Tested with UERANSIM version 2134f6b |
|
@jordanvrtanoski Please check this PR. From my side, it's ready to go. |
- Update M5GSUCIRegistrationServiceClient.cpp for proper SUCI handling - Modify nas_proc.cpp to fix MSIN decoding process - Adjust test_amf_procedures.cpp for debugging Signed-off-by: kmu-tm <kamar.mubasier@telenormaritime.com>
lucasgonze
force-pushed
the
fix_suci_agw
branch
from
7b3d321 to
a65903b
Compare
lucasgonze
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This simple PR fixes the issue with SUCI Profile B, as reported in #15444. The problem was the incorrect decoding of the MSIN. For example, the decoded IMSI was 99970008000, but the actual IMSI was 999700000068375 (as shown in the logs)
To sum up, the AMF failed to correctly parse the MSIN from the database which led to the IMSI being incorrect and the authentication procedure failing. The MSIN is received as 5 bytes of raw binary data in BCD (Binary Coded Decimal) format, with each byte representing two digits in reverse order. The original code assumed that the MSIN was a string of 10 digits and attempted to convert this in a wrong format (this resulted in the values being decoded incorrectly).
This PR changes the following:
There will be a new PR submitted for the SUCI documentation (there are some confusion regarding key generation).
Test Plan
The UEs that were tested w/ Profile B were IPhone and IPad using test keys from 3GPP TS.
Additional Information
EDIT: I am just going through the updates from v1.8. I do find it a bit odd that this issue was mentioned in the release notes here. Could there have been a rollback?
Security Considerations