chore: Clean up the AGW Make targets after the Bazel switch-over #14857

LKreutzer · 2023-01-18T10:49:12Z

Summary

Clean up the AGW Make targets after the Bazel switch-over
Remove fabric functions, AGW Make targets and CMakeLists files that are not needed anymore.
Note: The PR should be reviewed commit-by-commit to separate the different clean-up stages.

Test Plan

Link to workflow runs on this branch

Additional Information

After this PR has been merged the following tasks can be completed Tasks for after the Bazel to Make AGW switch-over #15101

github-actions · 2023-01-18T10:49:25Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by PR DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2023-01-18T10:49:40Z

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

github-actions · 2023-01-18T10:50:15Z

Oops! Looks like you failed the PR Check DCO. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the PR Check DCO after the last commit.

github-actions · 2023-01-18T10:51:35Z

Oops! Looks like you failed the Docs Lint & Check Generated Files In Sync.

Howto

♻️ Updated: ✅ The check is passing the Docs Lint & Check Generated Files In Sync after the last commit.

github-actions · 2023-01-18T10:51:57Z

Oops! Looks like you failed the AGW Build & Format Python.

Howto

Instructions on running the formatter and linter locally are provided in the format AGW doc
Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the AGW Build & Format Python after the last commit.

github-actions · 2023-01-19T12:06:36Z

Sudo Python test results

145 tests ±0 142 ✔️ +1 16m 15s ⏱️ -10s
  41 suites ±0     3 💤 ±0
    1 files ±0     0 ❌ - 1

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

♻️ This comment has been updated with latest results.

github-actions · 2023-01-19T13:42:35Z

CWF integration test results

  1 files ±  0 1 suites ±0 44m 46s ⏱️ + 32m 53s
32 tests -   8 6 ✔️ - 20 8 💤 - 3 18 ❌ +15
32 runs - 11 6 ✔️ - 23 8 💤 - 3 18 ❌ +15

For more details on these failures, see this check.

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

This pull request removes 8 tests.

magma/cwf/gateway/integ_tests ‑ TestBasicEnforcementWithSessionDRestarts
magma/cwf/gateway/integ_tests ‑ TestGxDisabledOmnipresentRules
magma/cwf/gateway/integ_tests ‑ TestGyReAuth
magma/cwf/gateway/integ_tests ‑ TestGyWithPermanentErrorCode
magma/cwf/gateway/integ_tests ‑ TestIdleTimer
magma/cwf/gateway/integ_tests ‑ TestIpfixEnforcement
magma/cwf/gateway/integ_tests ‑ TestMultiSessionProxyMonitorAndUsageReportEnforcement
magma/cwf/gateway/integ_tests ‑ TestOmnipresentRules

♻️ This comment has been updated with latest results.

github-actions · 2023-01-19T13:48:03Z

LTE Debian integration test results

171 tests ±0     0 ✔️ ±0 2h 12m 16s ⏱️ - 1m 56s
171 suites ±0     0 💤 ±0
171 files ±0 171 ❌ ±0

For more details on these failures, see this check.

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

♻️ This comment has been updated with latest results.

github-actions · 2023-01-19T14:56:13Z

Bazel unit-test results --config=asan

    1 files ±0 129 suites ±0 3m 20s ⏱️ ±0s
598 tests ±0 598 ✔️ ±0 0 💤 ±0 0 ❌ ±0
599 runs ±0 599 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

♻️ This comment has been updated with latest results.

github-actions · 2023-01-19T14:56:21Z

Bazel unit-test results --config=production

    1 files ±0 129 suites ±0 3m 8s ⏱️ ±0s
598 tests ±0 598 ✔️ ±0 0 💤 ±0 0 ❌ ±0
599 runs ±0 599 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

♻️ This comment has been updated with latest results.

github-actions · 2023-01-19T14:57:58Z

Bazel unit-test results

    1 files ±0 232 suites ±0 3m 22s ⏱️ -2s
719 tests ±0 719 ✔️ ±0 0 💤 ±0 0 ❌ ±0
720 runs ±0 720 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

♻️ This comment has been updated with latest results.

github-actions · 2023-02-13T15:16:56Z

FEG integration test results

31 tests - 1 28 ✔️ - 4 35m 12s ⏱️ + 17m 22s
31 suites - 1   0 💤 ±0
31 files - 1   3 ❌ +3

For more details on these failures, see this check.

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

This pull request removes 1 test.

s1aptests.test_no_security_mode_complete.TestNoSecurityModeComplete ‑ test_no_security_mode_complete

♻️ This comment has been updated with latest results.

lte/gateway/python/integ_tests/federated_tests/fabfile.py

github-actions · 2023-02-24T16:46:56Z

LTE containerizes integ test results - extended_tests_long

6 tests ±0 6 ✔️ ±0 46m 27s ⏱️ +27s
6 suites ±0 0 💤 ±0
6 files ±0 0 ❌ ±0

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

♻️ This comment has been updated with latest results.

github-actions · 2023-02-24T16:47:49Z

LTE containerizes integ test results - extended_tests

45 tests - 1 45 ✔️ - 1 55m 38s ⏱️ - 4m 9s
45 suites - 1   0 💤 ±0
45 files - 1   0 ❌ ±0

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

This pull request removes 1 test.

s1aptests.test_attach_detach_with_non_nat_dhcp_multi_ue_looped.TestAttachDetachWithNonNatDhcpMultiUeLooped ‑ test_attach_detach_with_non_nat_dhcp_multi_ue_looped

♻️ This comment has been updated with latest results.

github-actions · 2023-02-24T18:01:03Z

LTE containerizes integ test results - precommit

121 tests ±0 120 ✔️ ±0 1h 57m 6s ⏱️ - 36m 15s
121 suites ±0     1 💤 ±0
121 files ±0     0 ❌ ±0

Results for commit c605a1f. ± Comparison against base commit 79c60d2.

♻️ This comment has been updated with latest results.

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

maxhbr

LGTM

voisey · 2023-03-15T16:07:02Z

docs/readmes/howtos/package.md

Shouldn't this be removed from sidebars.json too?

voisey · 2023-03-15T16:14:54Z

lte/gateway/fabfile.py

@@ -301,47 +188,6 @@ def _setup_gateway(
    return gateway_connection, gateway_ip


-@task
-def integ_test(


Please migrate the relevant content from here to the docstring of integ_test_containerized, since its docstring refers to this function on line 242

voisey · 2023-03-15T16:16:06Z

lte/gateway/fabfile.py

-        c_gw.run('cp ' + exec_path + ' ' + dest_path, warn=True)
-
-
-def _build_magma(c_gw):


I believe this is still referred to on line 275, i.e. in _build_and_start_magma

voisey · 2023-03-15T16:19:41Z

orc8r/tools/fab/pkg.py

@@ -15,13 +15,6 @@

 from fabric import Connection

-# Local changes are only allowed in files specified in the EXCLUDE_FILE_LIST
-EXCLUDE_FILE_LIST = [
-    os.path.realpath(x) for x in [


There is now an unused import of os at the top of the file. Could you please remove it?

LKreutzer self-assigned this Jan 18, 2023

pull-request-size bot added the size/XXL Denotes a Pull Request that changes 1000+ lines. label Jan 18, 2023

github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: docs Documentation-related issue component: feg FEG-gateway related issues labels Jan 18, 2023

LKreutzer mentioned this pull request Jan 18, 2023

Make to Bazel switchover for the AGW #14835

Open

LKreutzer force-pushed the bazel-switchover branch 2 times, most recently from 6b52d91 to 12dbf89 Compare January 18, 2023 13:13

LKreutzer changed the title ~~POC - WIP Steps for Bazel switchover~~ chore: POC - WIP Steps for Bazel switchover Jan 18, 2023

LKreutzer force-pushed the bazel-switchover branch from 12dbf89 to efb43a9 Compare January 19, 2023 10:55

LKreutzer force-pushed the bazel-switchover branch 4 times, most recently from 7957e69 to bedb877 Compare January 30, 2023 08:39

LKreutzer force-pushed the bazel-switchover branch 4 times, most recently from 62aa53a to ec6b9c8 Compare February 2, 2023 09:12

LKreutzer linked an issue Feb 10, 2023 that may be closed by this pull request

Make to Bazel switchover for the AGW #14835

Open

LKreutzer force-pushed the bazel-switchover branch 2 times, most recently from b994124 to 980e8c0 Compare February 13, 2023 13:34

LKreutzer force-pushed the bazel-switchover branch from 980e8c0 to 754d938 Compare February 16, 2023 08:34

github-actions bot reviewed Feb 16, 2023

View reviewed changes

lte/gateway/python/integ_tests/federated_tests/fabfile.py Outdated Show resolved Hide resolved

lte/gateway/python/integ_tests/federated_tests/fabfile.py Outdated Show resolved Hide resolved

lte/gateway/python/integ_tests/federated_tests/fabfile.py Outdated Show resolved Hide resolved

LKreutzer force-pushed the bazel-switchover branch 3 times, most recently from f2669bb to 123246c Compare February 20, 2023 13:45

github-actions bot added the component: orc8r Orchestrator-related issue label Feb 20, 2023

LKreutzer force-pushed the bazel-switchover branch from 123246c to cf4d7cd Compare February 24, 2023 14:22

github-actions bot removed the component: orc8r Orchestrator-related issue label Feb 24, 2023

LKreutzer force-pushed the bazel-switchover branch from cf4d7cd to fe9bf7d Compare February 27, 2023 08:12

LKreutzer changed the title ~~chore: POC - WIP Steps for Bazel switchover~~ chore: Remove duplicated Make workflows for the Bazel switch-over and clean up Make targets Mar 7, 2023

LKreutzer force-pushed the bazel-switchover branch 2 times, most recently from f1ad4f6 to 0ccea2c Compare March 9, 2023 12:54

LKreutzer added 4 commits March 13, 2023 11:21

chore: Remove commands from lte/gateway/fabfile.py

870e0ee

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

chore: Remove build-magma.sh, lockfiles and pydep

f67b74c

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

chore: Remove Make commands

0918dc4

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

chore: Remove all CMakeLists.txt files

c605a1f

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

LKreutzer force-pushed the bazel-switchover branch from 0ccea2c to c605a1f Compare March 13, 2023 10:24

github-actions bot removed the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Mar 13, 2023

LKreutzer changed the title ~~chore: Remove duplicated Make workflows for the Bazel switch-over and clean up Make targets~~ chore: Clean up the AGW Make targets after the Bazel switch-over Mar 13, 2023

maxhbr approved these changes Mar 13, 2023

View reviewed changes

LKreutzer added the bazel-cleanup BE fixups that came out of the Bazelification effort label Mar 13, 2023

voisey reviewed Mar 15, 2023

View reviewed changes

LKreutzer removed their assignment Mar 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Clean up the AGW Make targets after the Bazel switch-over #14857

chore: Clean up the AGW Make targets after the Bazel switch-over #14857

LKreutzer commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 18, 2023

github-actions bot commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Feb 13, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023 •

edited

Loading

maxhbr left a comment

voisey Mar 15, 2023

voisey Mar 15, 2023

voisey Mar 15, 2023

voisey Mar 15, 2023

		c_gw.run('cp ' + exec_path + ' ' + dest_path, warn=True)


		def _build_magma(c_gw):

chore: Clean up the AGW Make targets after the Bazel switch-over #14857

Are you sure you want to change the base?

chore: Clean up the AGW Make targets after the Bazel switch-over #14857

Conversation

LKreutzer commented Jan 18, 2023 • edited Loading

Summary

Test Plan

Additional Information

github-actions bot commented Jan 18, 2023

Howto

More info

github-actions bot commented Jan 18, 2023 • edited Loading

github-actions bot commented Jan 18, 2023 • edited Loading

Howto

github-actions bot commented Jan 18, 2023 • edited Loading

Howto

github-actions bot commented Jan 18, 2023 • edited Loading

Howto

github-actions bot commented Jan 19, 2023 • edited Loading

Sudo Python test results

github-actions bot commented Jan 19, 2023 • edited Loading

CWF integration test results

github-actions bot commented Jan 19, 2023 • edited Loading

LTE Debian integration test results

github-actions bot commented Jan 19, 2023 • edited Loading

Bazel unit-test results --config=asan

github-actions bot commented Jan 19, 2023 • edited Loading

Bazel unit-test results --config=production

github-actions bot commented Jan 19, 2023 • edited Loading

Bazel unit-test results

github-actions bot commented Feb 13, 2023 • edited Loading

FEG integration test results

github-actions bot commented Feb 24, 2023 • edited Loading

LTE containerizes integ test results - extended_tests_long

github-actions bot commented Feb 24, 2023 • edited Loading

LTE containerizes integ test results - extended_tests

github-actions bot commented Feb 24, 2023 • edited Loading

LTE containerizes integ test results - precommit

maxhbr left a comment

Choose a reason for hiding this comment

voisey Mar 15, 2023

Choose a reason for hiding this comment

voisey Mar 15, 2023

Choose a reason for hiding this comment

voisey Mar 15, 2023

Choose a reason for hiding this comment

voisey Mar 15, 2023

Choose a reason for hiding this comment

LKreutzer commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Jan 19, 2023 •

edited

Loading

github-actions bot commented Feb 13, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023 •

edited

Loading

github-actions bot commented Feb 24, 2023 •

edited

Loading