Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Add docker-compose support #6890

Merged
merged 9 commits into from
Mar 20, 2020
Merged

Add docker-compose support #6890

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0d86b00
Add docker-compose support
cmuench Mar 19, 2020
1e150bb
Fix markdown style violations
cmuench Mar 19, 2020
364b7db
Added additional description of docker setup
cmuench Mar 19, 2020
015f7e4
Update README.md
cmuench Mar 19, 2020
92204b1
Add further instruction of the docker setup
cmuench Mar 19, 2020
c18bb08
Fix lint errors
cmuench Mar 19, 2020
4a0492f
Remove trailing spaces
cmuench Mar 19, 2020
eec2235
Remove wrong quotes
cmuench Mar 19, 2020
53798cd
Merge branch 'master' into docker-compose-setup
hguthrie Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update README.md 
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
  • Loading branch information
@cmuench @hguthrie
cmuench and hguthrie authored Mar 19, 2020
commit 015f7e49e9be7c38434f3cd29928066680c603aa
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ exclude:

## Docker (docker-compose)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add some context to this feature, can you add the following information in a summary before the instructions:

  1. What are the use cases for using this feature?
  2. Do users need anything else besides docker installed?
  3. Will this work from a fresh copy of the repo or do people need to perform some pre-requisite steps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite simple. Only a docker installation is needed. Should work in every repo/fork. I can add an additional comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcalcaben I added an description. Please review it. I am not a native speaker.


Docker provide an easy and fastr way to build the documentation for developers. There is no need to install any
Docker provides a quick and easy way to build and preview the documentation. You do not need to install Ruby dependencies manually. This Docker solution launches Jekyll inside the container in `watch` mode.```
hguthrie marked this conversation as resolved.
Show resolved Hide resolved
ruby dependency manually. The provided setup starts Jekyll inside the container in watch mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this line now, since the updates were made. 🙂

Every change of a markdown file will automatically trigger a rebuild of the documentation.
hguthrie marked this conversation as resolved.
Show resolved Hide resolved

Expand Down