Move the DoubleSlashChecker to a separate file as a part of custom mo…

…dule
magento · Jan 15, 2019 · f1fcefd · f1fcefd
1 parent ac2ed20
commit f1fcefd
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 21 deletions.
diff --git a/Rakefile b/Rakefile
@@ -14,6 +14,7 @@ require 'colorator'
 # Load ruby files with helper methods from the 'rakelib/' directory
 require_relative 'rakelib/link-checker.rb'
 require_relative 'rakelib/converter.rb'
+require_relative 'rakelib/double-slash-check.rb'
 
 desc "Same as 'rake', 'rake preview'"
 task default: %w[preview]

diff --git a/rakelib/double-slash-check.rb b/rakelib/double-slash-check.rb
@@ -0,0 +1,20 @@
+# Custom check for html-proofer to find double forward slashes in URLs.
+module LinkChecker
+  class DoubleSlashCheck < ::HTMLProofer::Check
+    def slash?
+      return false if @link.href.nil?
+      @link.href.match %r{\w//}
+    end
+
+    def run
+      @html.css('a').each do |node|
+        @link = create_element(node)
+        line = node.line
+
+        if slash?
+          return add_issue("Remove double forward slashes from URLs", line: line)
+        end
+      end
+    end
+  end
+end
diff --git a/rakelib/link-checker.rb b/rakelib/link-checker.rb
@@ -1,26 +1,5 @@
 # frozen_string_literal: true
 
-# Custom class to find double forward slashes in URLs.
-
-class DoubleSlashCheck < ::HTMLProofer::Check
-
-  def slash?
-    return false if @link.href.nil?
-    @link.href.match /\w\/\//
-  end
-
-  def run
-    @html.css('a').each do |node|
-      @link = create_element(node)
-      line = node.line
-
-      if slash?
-        return add_issue("Remove double forward slashes from URLs", line: line)
-      end
-    end
-  end
-end
-
 # Helper methods to configure  and run html-proofer
 module LinkChecker
   # Run html-proofer to check the generated HTML pages