Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Commit

Permalink
Fix 404s on External Links (#8348)
Browse files Browse the repository at this point in the history
* Fix 404s on External Links

* Small change to avoid conflict

* Update src/guides/v2.3/coding-standards/docblock-standard-general.md

Co-authored-by: Dmitry Shevtsov <12731225+dshevtsov@users.noreply.github.com>

* Update src/guides/v2.3/config-guide/secy/secy-xframe.md

Co-authored-by: Dmitry Shevtsov <12731225+dshevtsov@users.noreply.github.com>

* Update src/guides/v2.3/config-guide/varnish/config-varnish-advanced.md

Co-authored-by: Dmitry Shevtsov <12731225+dshevtsov@users.noreply.github.com>

Co-authored-by: Barny Shergold <barnyshergold@MacBook-Pro-9.local>
Co-authored-by: Dmitry Shevtsov <12731225+dshevtsov@users.noreply.github.com>
Co-authored-by: Margaret Eker <meker@adobe.com>
  • Loading branch information
4 people authored Dec 15, 2020
1 parent 1506ff7 commit db97beb
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/cloud/cdn/fastly-vcl-badreferer.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Before creating a snippet based on this example, review the values to determine

- `name` — Name for the VCL snippet. For this example, we used `block_bad_referrer`.

- `dynamic` — Value 0 indicates a [regular snippet](https://docs.fastly.com/guides/vcl-snippets/using-regular-vcl-snippets) to upload to the versioned VCL for the Fastly configuration.
- `dynamic` — Value 0 indicates a [regular snippet](https://docs.fastly.com/en/guides/using-regular-vcl-snippets) to upload to the versioned VCL for the Fastly configuration.

- `priority` — Determines when the VCL snippet runs. The priority is `5` to run this snippet code before any of the default Magento VCL snippets (`magentomodule_*`) assigned a priority of 50. You must set the priority for each custom snippet higher or lower than 50 depending on when you want your snippet to run. Snippets with lower priority numbers run first.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The goal of this standard is to unify usage of code DocBlocks for all files, not

The following is assumed by default:

* Formatting according to the [phpDocumentor](https://docs.phpdoc.org/latest/references/phpdoc/basic-syntax.html#what-is-a-docblock){:target="_blank"} standard
* Formatting according to the [phpDocumentor](https://docs.phpdoc.org/latest/guide/references/phpdoc/basic-syntax.html#basic-syntax) standard
* Requirements apply for all files regardless of programming language, but a DocBlock standard for the particular language may override it.

## General principles
Expand Down
1 change: 0 additions & 1 deletion src/guides/v2.3/config-guide/secy/secy-xframe.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,3 @@ Look for the `X-Frame-Options` value in the headers.

* [mozilla.org](https://developer.mozilla.org/en-US/docs/HTTP/X-Frame-Options)
* [security.stackexchange.com](http://security.stackexchange.com/questions/67889/why-do-browsers-enforce-the-same-origin-security-policy-on-iframes)
* [MSDN blog](http://blogs.msdn.com/b/ieinternals/archive/2010/03/30/combating-clickjacking-with-x-frame-options.aspx)
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ functional_areas:

Varnish provides several features that prevent customers from experiencing long delays and timeouts when the Magento server is not functioning properly. These features can be configured in the `default.vcl` file. This topic describes the additions that Magento provides in the VCL (Varnish Configuration Language) file you download from [Magento Admin](https://glossary.magento.com/magento-admin).

See the [Varnish Reference Manual](https://www.varnish-cache.org/docs/4.1/reference/index.html) for details about using the Varnish Configuration Language.
See the [Varnish Reference Manual](https://varnish-cache.org/docs/6.5/reference/index.html) for details about using the Varnish Configuration Language.

## Health check {#health}

Expand All @@ -31,7 +31,7 @@ Every 5 seconds, this health check calls the `pub/health_check.php` script. This

The `health_check.php` script is located in the `pub` directory. If your Magento root directory is `pub`, then be sure to change the path in the `url` parameter from `/pub/health_check.php` to `health_check.php`.

For more information, see the [Varnish health checks](https://varnish-cache.org/docs/4.1/users-guide/vcl-backends.html?highlight=health%20check#health-checks) documentation.
For more information, see the [Varnish health checks](https://varnish-cache.org/docs/6.5/users-guide/vcl-backends.html#health-checks) documentation.

## Grace mode {#grace}

Expand Down Expand Up @@ -82,8 +82,7 @@ bin/magento cache:flush

Saint mode is not part of the main Varnish package. It is a separately-versioned vmod that must be downloaded and installed. As a result, you should re-compile Varnish from source, as described in the following articles:

* [Installing Varnish 5.1](https://varnish-cache.org/docs/5.1/installation/index.html)
* [Installing Varnish 4.1](https://varnish-cache.org/docs/4.1/installation/install.html) (Stable)
* [Installing Varnish 6.5](https://varnish-cache.org/docs/6.5/installation/index.html)

After you've recompiled, you can install the Saint mode [module](https://glossary.magento.com/module). In general, follow these steps:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ functional_areas:

Installing the Varnish software is beyond the scope of this guide. For more information about installing Varnish, see:

* [installation wiki](http://wiki.mikejung.biz/Varnish)
* [Installation wiki](https://www.varnish-software.com/wiki/start/index.html)
* [Varnish installation guides](https://www.varnish-cache.org/docs)
* [How to install Varnish (Tecmint)](http://www.tecmint.com/install-varnish-cache-web-accelerator)

Expand Down
2 changes: 1 addition & 1 deletion src/guides/v2.3/extension-dev-guide/cli-cmds/cli-howto.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Following is a summary of the process:
```

{:.bs-callout-info}
Style the output text by using `<error>`, `<info>`, or `<comment>` tags. See [Symfony](https://symfony.com/doc/master/console/coloring.html){:target="_blank"} documentation for more information about styling.
Style the output text by using `<error>`, `<info>`, or `<comment>` tags. See [Symfony](https://symfony.com/doc/current/console/coloring.html){:target="_blank"} documentation for more information about styling.

1. Declare your Command class in `Magento\Framework\Console\CommandListInterface` and configure the command name using dependency injection (`<your component root dir>/etc/di.xml`):

Expand Down
2 changes: 1 addition & 1 deletion src/guides/v2.4/test/integration/annotations.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Data Fixture|`@magentoDataFixture`|`@magentoDataFixture <script_filename>|<metho
Data Fixture Before Transaction|`@magentoDataFixtureBeforeTransaction`|`@magentoDataFixtureBeforeTransaction <script_filename>|<method_name>`|Points to a class or a method which creates testing entities (fixtures) for test execution before the transaction has begun. You will need to implement a rollback file for changes made here. (e.g. Fixture file my_fixture.php would also require a my_fixture_rollback.php that reverts the original fixture's changed.)
Application Area|`@magentoAppArea`|`@magentoAppArea adminhtml|frontend|global`|Configures test environment in the context of specified application area.
Enable/Disable Cache|`@magentoCache`|`@magentoCache <type>|all enabled|disabled`|Enables or disables certain cache segment or all of them to prevent isolation problems.
Indexer Dimension Mode|`@magentoIndexerDimensionMode`|`@magentoIndexerDimensionMode <indexer> <mode>`|Sets the indexer dimension mode for the test run. More information can be found in the [DevBlog](https://community.magento.com/t5/Magento-DevBlog/Indexers-parallelization-and-optimization/ba-p/104922_).
Indexer Dimension Mode|`@magentoIndexerDimensionMode`|`@magentoIndexerDimensionMode <indexer> <mode>`|Sets the indexer dimension mode for the test run. More information can be found in the [DevBlog](https://community.magento.com/t5/Magento-DevBlog/Indexers-parallelization-and-optimization/ba-p/104922).
Register Components|`@magentoComponentsDir`|`@magentoComponentsDir <dir_path>`|Registers fixture components from specified directory (recursively). Unregisters the components after the test is finished.

### Applying annotations
Expand Down

0 comments on commit db97beb

Please sign in to comment.