Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PushButton API surface for variant clarity #444

Open
4 tasks
GroovinChip opened this issue Jul 5, 2023 · 0 comments
Open
4 tasks

Refactor PushButton API surface for variant clarity #444

GroovinChip opened this issue Jul 5, 2023 · 0 comments
Labels
improvement Improvements to existing features widget
Milestone
Version 3.0: Sequ...

Comments

@GroovinChip
Copy link
Collaborator

According to the Sonoma Figma Kit, there are three variants of push buttons:

  • primary
  • secondary
  • destructive

Push Buttons

Styling Requirements:

  • The background color of primary buttons should always be the system accent color or the color set in PushButtonThemeData.
  • The background color of secondary buttons should always be the default white/dark grey color unless overridden by PushButtonThemeData.
  • The background color of destructive buttons should always be the default white/dark grey, and the button's text should always be styled to the shade of red appropriate for current theme. Destructive buttons should not respect the background color set by PushButtonThemeData.

Implementation Steps

Tasks
Preview Give feedback
@GroovinChip GroovinChip added the improvement Improvements to existing features label Jul 5, 2023
@GroovinChip GroovinChip moved this to To Do in macos_ui Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvements to existing features widget
Projects
macos_ui
Status: To Do
Milestone
Version 3.0: Sequoia Parity
Development

No branches or pull requests
1 participant
@GroovinChip