Don't like to use side-effects in if condition

machakann · Sep 27, 2018 · f38bbb0 · f38bbb0
1 parent 06b1782
commit f38bbb0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/autoload/highlightedyank.vim b/autoload/highlightedyank.vim
@@ -194,7 +194,8 @@ function! s:glow(region, hi_group, duration) abort "{{{
   if !empty(s:quenchtask) && !s:quenchtask.hasdone()
     call s:quenchtask.trigger()
   endif
-  if !highlight.show(a:hi_group)
+  let succeeded = highlight.show(a:hi_group)
+  if !succeeded
     return
   endif
   if !has('patch-8.0.1476') && has('patch-8.0.1449')