Solved bug when timeout does not find container

ma7moudat · Jul 24, 2017 · a5b4c10 · a5b4c10
1 parent 9e06b5f
commit a5b4c10
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/dist/build.js b/dist/build.js
diff --git a/dist/build.js.map b/dist/build.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vue-ripple-directive",
-  "version": "1.0.10",
+  "version": "1.0.11",
   "description": "Vue Material Ripple Effect Directive",
   "main": "src/ripple.js",
   "repository": {

diff --git a/src/ripple.js b/src/ripple.js
@@ -84,17 +84,23 @@ export default {
                         ripple.style.backgroundColor = "rgba(0, 0, 0, 0)";
                     }, 250);
 
+                    // Timeout set to get a smooth removal of the ripple
                     setTimeout(function() {
-                        rippleContainer.parentNode.removeChild(rippleContainer);
+                        // Conditional to avoid not finding parent when to many ripples are executed
+                        if (rippleContainer.parentNode)
+                            rippleContainer.parentNode.removeChild(rippleContainer);
                     }, 850);
                 })
             } else {
                 setTimeout(function() {
                     ripple.style.backgroundColor = "rgba(0, 0, 0, 0)";
                 }, 250);
 
+                // Timeout set to get a smooth removal of the ripple
                 setTimeout(function() {
-                    rippleContainer.parentNode.removeChild(rippleContainer);
+                    // Conditional to avoid not finding parent when to many ripples are executed
+                    if (rippleContainer.parentNode)
+                        rippleContainer.parentNode.removeChild(rippleContainer);
                 }, 850);
             }
         }